forked from rails/rails
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Don't stream redirect controller responses
They don't need to be streamed and by including ActiveStorage::Streaming, they spin up new threads which can cause problems with connection pools as detailed in rails#44242
- Loading branch information
1 parent
e95ed22
commit 4b99fed
Showing
4 changed files
with
12 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,11 @@ | ||
* Don't stream responses in redirect mode | ||
|
||
Previously, both redirect mode and proxy mode streamed their | ||
responses which caused a new thread to be created, and could end | ||
up leaking connections in the connection pool. But since redirect | ||
mode doesn't actually send any data, it doesn't need to be | ||
streamed. | ||
|
||
*Luke Lau* | ||
|
||
Please check [7-0-stable](https://github.com/rails/rails/blob/7-0-stable/activestorage/CHANGELOG.md) for previous changes. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters