Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[B] issue with account setting profile tabs #1812

Closed
githubertus opened this issue Aug 26, 2020 · 2 comments
Closed

[B] issue with account setting profile tabs #1812

githubertus opened this issue Aug 26, 2020 · 2 comments

Comments

@githubertus
Copy link
Contributor

githubertus commented Aug 26, 2020

please verify
components\OssnProfile\plugins\default\profile\menus\edittabs.php

I'm not quite sure what you were trying to achieve there ...
at least I'm not getting $params['name'] on my site
and so all my tabs look the same like 'profile-edit-tab-item-'
maybe you meant $args['name'] ?

and when I'm trying to pass my own class, it's not merged, but becomes a stand-alone-class

@lianglee
Copy link
Member

Sorry it should be args['name'] its mistyped

@lianglee
Copy link
Member

Maybe we can remove it completely profile-edit-tab-item-{$params['name']} as if someone wanted to set name they can use a class arg.

@lianglee lianglee changed the title issue with account setting profile tabs [B] issue with account setting profile tabs Nov 6, 2020
@lianglee lianglee closed this as completed Nov 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants