Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[E] placeholder for input/dropdown #1813

Closed
githubertus opened this issue Sep 1, 2020 · 1 comment
Closed

[E] placeholder for input/dropdown #1813

githubertus opened this issue Sep 1, 2020 · 1 comment

Comments

@githubertus
Copy link
Contributor

While working on the next release of the CountrySelector component
I found that there's currently no way to pass a real placeholder to the input/dropdown plugin
which would be a nice to have feature with the next Ossn.
I'm currently using a label instead but it may disturb the overall appearance
as on the registration form ...
options-placeholder

Here that bold printed "Country" doesn't really look good - a placeholder as already shown looks much nicer.
So, for now I ended with some extra jquery like
$('#country-selector').prepend("<option value=\"\" disabled selected hidden>" + Ossn.Print('com:country:selector:label') + "</option>");

but of course it would be smarter if input/dropdown would do that automatically if a placeholder is passed.

@lianglee
Copy link
Member

lianglee commented Nov 6, 2020

Done

@lianglee lianglee closed this as completed Nov 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants