Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[E] OssnPhotos -> Fancybox issue and feature request #1858

Closed
githubertus opened this issue Mar 2, 2021 · 3 comments
Closed

[E] OssnPhotos -> Fancybox issue and feature request #1858

githubertus opened this issue Mar 2, 2021 · 3 comments

Comments

@githubertus
Copy link
Contributor

  1. currently used version 3.0.47 is throwing "Uncaught (in promise) TypeError: Not in fullscreen mode" whenever closing the gallery
    I have tested 3.1.20 which would fix this issue. A little outdated, too. But later versions seem to be no more really compatible with Ossn's jquery

  2. I'd suggest to load the Fancybox unconditionally to allow other components making use of it.

@lianglee
Copy link
Member

lianglee commented Apr 6, 2021

Will later version work with jQuery 2.2.x ? I am thinking to move to JQuery 3.x but its too much work we need to rewrite a OssnPagination 3rd party library and boostrap 3.x didn't work with 3.x

@githubertus
Copy link
Contributor Author

Yes, I have just verified Fancybox 3.1.20 to work fine with jquery-2.2.4.min.js (as used in latest Ossn here on Github)

@lianglee
Copy link
Member

Updated to 3.5.7

Others compnent may include;

ossn_load_external_css('jquery.fancybox.min.css');
ossn_load_external_js('jquery.fancybox.min.js');

@lianglee lianglee changed the title OssnPhotos -> Fancybox issue and feature request [E] OssnPhotos -> Fancybox issue and feature request Apr 16, 2021
lianglee added a commit that referenced this issue Apr 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants