Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[E] Like Comment on object #1868

Closed
lianglee opened this issue Apr 5, 2021 · 2 comments
Closed

[E] Like Comment on object #1868

lianglee opened this issue Apr 5, 2021 · 2 comments

Comments

@lianglee
Copy link
Member

lianglee commented Apr 5, 2021

This requires to refine the OSSN notifications for like:annotation, right now comments added either on posts or entities

@lianglee
Copy link
Member Author

lianglee commented Apr 5, 2021

All the devs utlizing ossn_add_hook('notification:view', 'like:annotation', '...'); will need to update to:

ossn_add_hook('notification:view', 'like:annotation:comments:entity', '...');
ossn_add_hook('notification:view', 'like:annotation:comments:object', '...');
ossn_add_hook('notification:view', 'like:annotation:comments:post'...);

@lianglee
Copy link
Member Author

lianglee commented Apr 5, 2021

  • We would require to delete all like:annotation notification during upgrade.
  • Language files need to be adjusted for ossn:notifications:like:annotation or a notification view if its like:annotation then use old langs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant