Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[E] Check the OssnEmbed for videos links issues #1957

Closed
lianglee opened this issue May 19, 2021 · 1 comment
Closed

[E] Check the OssnEmbed for videos links issues #1957

lianglee opened this issue May 19, 2021 · 1 comment

Comments

@lianglee
Copy link
Member

lianglee commented May 19, 2021 •
edited

E.g Metacafe
@lianglee
Copy link
Member Author

lianglee commented May 21, 2021 •
edited

  1. Youtube works fine
  2. Metacafe works but the issue was its using https we need to change it // to load depends on ssl or not,
  3. Vimeo works
  4. Dailymotion works
  5. Hulu Removed as its paid service now no public videos!

Change a layout for BS..5 ration ration-16x9

lianglee added a commit that referenced this issue May 21, 2021
@lianglee
[E] Check the OssnEmbed for videos links issues #1957
83ac38a
githubertus added a commit to githubertus/opensource-socialnetwork that referenced this issue Dec 14, 2021
@githubertus
fixed unallowed <div> inside paragraph again
26d28b8 
I had fixed that already in Oct 2016 (see history) but it became reverted back to wrong html again with opensource-socialnetwork#1957
this way the post is getting messed up because browsers are putting that div outside of the paragraph
one result is that READMORE fails because of that split

plus:
- removed no more available old bootstrap classes embed-responsive
- fix for missing video id with youtu.be videos ('undefined variable $guid' logs)
@githubertus githubertus mentioned this issue Dec 14, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lianglee