Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[B] Deleting a group should remove group:joinrequest records #2066

Closed
githubertus opened this issue Jan 21, 2022 · 3 comments
Closed

[B] Deleting a group should remove group:joinrequest records #2066

githubertus opened this issue Jan 21, 2022 · 3 comments

Comments

@githubertus
Copy link
Contributor

  • A creates group TMP
  • B requests membership for TMP
  • A deletes group TMP

A opening notifications gives
PHP WARNING: "Attempt to read property "guid" on bool" in file classes/OssnObject.php (line 157)
PHP WARNING: "Attempt to read property "title" on bool" in file components/OssnGroups/ossn_com.php (line 436)
@lianglee
Copy link
Member

Will check :)

@lianglee lianglee changed the title Deleting a group should remove group:joinrequest records [B] Deleting a group should remove group:joinrequest records Jan 24, 2022
@githubertus
Copy link
Contributor Author

Independent of that,
Whatever is causing no valid object to be returned here, getObjectById() should immediately return false here instead of proceeding and calling Entities

@lianglee
Copy link
Member

agree

lianglee added a commit that referenced this issue Feb 17, 2022
@lianglee
Update OssnObject.php
d924d79 
#2066
lianglee added a commit that referenced this issue Apr 17, 2022
@lianglee
Move class from relationships lib to group #2066
63addc4
lianglee added a commit that referenced this issue Apr 17, 2022
@lianglee
[B] Deleting a group should remove group:joinrequest records #2066
964e95a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lianglee @githubertus