Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[B] missing checkbox-block span style #2145

Closed
githubertus opened this issue Apr 11, 2022 · 4 comments
Closed

[B] missing checkbox-block span style #2145

githubertus opened this issue Apr 11, 2022 · 4 comments
Assignees
@lianglee

Comments

@githubertus
Copy link
Contributor

not available in Goblue and should be styled according to radio-block

missing-checkbox-span-style
@lianglee
Copy link
Member

Yup :)

@lianglee lianglee self-assigned this Apr 12, 2022
@githubertus
Copy link
Contributor Author

Well, meanwhile I had a closer look into all that stuff and I'm wondering why we are not simply using bootstrap classes according to https://getbootstrap.com/docs/5.0/forms/checks-radios/ ?

This way we could get rid of a lot of extra css in our themes ... :)

@lianglee
Copy link
Member

Yes but now if we use it now we may require to fix already developed stuff

@lianglee
Copy link
Member

Suppose some component using custom css and now if we add bs classes it may make those css appears strange in custom usages

lianglee added a commit that referenced this issue May 29, 2022
@lianglee
[B] missing checkbox-block span style #2145
df8a805
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lianglee lianglee

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lianglee @githubertus