Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[B] wrong class extending in all input plugins #2146

Closed
githubertus opened this issue Apr 12, 2022 · 1 comment
Closed

[B] wrong class extending in all input plugins #2146

githubertus opened this issue Apr 12, 2022 · 1 comment

Comments

@githubertus
Copy link
Contributor

githubertus commented Apr 12, 2022 •
edited
Loading

The changes which have been applied for #1635 don't work

it has to be

if(isset($params['class'])){
	//[B] strangeness of class extending in input modules #1635
	$params['class'] = $class .' '. $params['class'];
}

Otherwise the formerly extended class will be overwritten later in array_merge again
lianglee added a commit that referenced this issue Apr 21, 2022
@lianglee
[B] wrong class extending in all input plugins #2146
36513b8
lianglee added a commit that referenced this issue Apr 21, 2022
@lianglee
dropdown #2146
2a58862
lianglee added a commit that referenced this issue Apr 21, 2022
@lianglee
Radio #2146
e8aa618
lianglee added a commit that referenced this issue Apr 21, 2022
@lianglee
text #2146
ee75a0f
lianglee added a commit that referenced this issue Apr 21, 2022
@lianglee
Textarea #2146
6481cd1
@lianglee
Copy link
Member

Yes :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lianglee @githubertus