Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[B] btn-sm have no effect #2153

Closed
lianglee opened this issue May 2, 2022 · 5 comments
Closed

[B] btn-sm have no effect #2153

lianglee opened this issue May 2, 2022 · 5 comments

Comments

@lianglee
Copy link
Member

lianglee commented May 2, 2022

No description provided.

@githubertus
Copy link
Contributor

oops yes. time to replace bootstrap 5.0.0-beta3 by 5.1.3, I think. ;)
just tried that on GbG and the issue is fixed.
but it's introducing some other surprises like underlined links here and there and these little red spots :))
red-notifs

@lianglee
Copy link
Member Author

lianglee commented May 3, 2022 via email

@lianglee
Copy link
Member Author

lianglee commented May 4, 2022

image every upgrade of bs we need to add these from previous versions.

But I still need to find why btn-sm have no effect

@githubertus
Copy link
Contributor

' every upgrade of bs we need to add these'
No, for sure I won't do this - at least not with a theme of mine.
If this is really necesarry for keeping backward compatibility of some old compoments, I would add it to my theme's CSS - but leave bootstrap css untouched.

@lianglee
Copy link
Member Author

lianglee commented May 4, 2022 via email

lianglee added a commit that referenced this issue May 29, 2022
lianglee added a commit that referenced this issue May 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants