removed obsolete code (typo)

[githubertus]

i think it was a typo in first place: it was $user_posts here, but entities_pairs are filled with $userS_posts.
so $user_posts never becomes a part of the query
on the other hand the id of the profile page owner is guaranteed to be included already in the friends array on line 172, so it's an unnecessary duplicate anyway and can be removed

[lianglee]

Yes its was typo and fixing typo results wrong result :)
However :

This line is useless then without entities_pairs name, value this line will never be called./

Dump of getUserPosts when friend is loggedin and seeing user profile, here entities_pairs[1] is useless as it have no name param.

With non friend seeing user profile

I think it worked because if not a friend (emd0.value=2) is set in wheres.

So these lines are useless

Few things getting in my mind:

1. What if userA and userB are friends, userC and UserB are friends, userA blocked UserC, userA posted on UserB and What will happen if userC visits userB wall.

[lianglee]

If I am right regarding usless two lines then we need to adjust if statement as the lines not needed.
And the above thing in my mind will be taken care about user blocks component.

What do you think?

[lianglee]

This can be now closed because of above two commits resolves the problem.