Fixed: jfif photo uploads don't work

[AntzCode]

Background

Since a Windows update in December 2019, Microsoft has configured all of its customers' computers to use .jfif instead of .jpg as the default extension when saving JPEG files:

https://answers.microsoft.com/en-us/windows/forum/all/jpg-vs-jfif-extension/f66875d7-4780-4d55-b8da-9387de4139d4

Since the .jfif protocol has not been widely popular, it is not presently supported by OSSN.

We need to make sure that .jfif uploads work as well as .jpg uploads do.

Solution

In a handful of places, an configuration is sent to OssnFile::setExtension() that defines allowed file types. Wherever there has been found ".jpg" and ".jpeg" file extensions in that configuration, I have added ".jfif".

I also added the reverse mapping (".jfif" to "image/jpeg" mime type) in the applicable places.

The original issue is found here: jfif photo uploads don't work #7

The revision in the main branch of my OSSN fork is here: baa0cb71e587c36ff7499aa5b60c9114d8594d70

Notes

• This affects a Third Party library (phpMailer).
• This is a high priority bug because it probably affects most Windows users.

[lianglee]

Did you tried to use jfif photos once this patch? did it worked in profile cover, profile photo, album photos, wall posts?

[lianglee]

Thanks for the pull, let me know above :) Once confirmed I shall merge it.

[AntzCode]

Thanks @lianglee, I have tested those four cases you have listed there and confirmed that it works.