[E] optimized getMyGroups()

[githubertus]

same logic again:
if user is approved, it needs no extra isMember() check

[githubertus]

allthough db queries are a bit reduced now
this one still gives me a headache because we're running in here with every bootchat cycle
only to get those group entries in the left sidebar one time

should find a way to move that ossn_get_user_groups() call outside of group init to a page load callback ...

[lianglee]

allthough db queries are a bit reduced now this one still gives me a headache because we're running in here with every bootchat cycle only to get those group entries in the left sidebar one time

should find a way to move that ossn_get_user_groups() call outside of group init to a page load callback ...

I think we can use the Session and store user group in session and each time loading from session instead of DB and we can add a hook or in action file if new group added by user we can update session. Maybe this is bad idea but that is only possible thing I can think of ;)

[githubertus]

Yeah, storing in session would be the only way to call it only ONCE,

What I just tried successfully instead is:

function ossn_view_sections_menu($menu, $type = 'frontend') {
error_log('VIEW SECTIONS');
ossn_trigger_callback('sections_menu', 'add:entries', null);
return ossn_view_menu($menu, "menus/sections/{$menu}");
}

and in Groups com file
ossn_register_callback('sections_menu', 'add:entries', 'ossn_group_sidebar_entries');
and moving the complete group menu registering inside that callback function.

Since ossn_view_sections_menu() gets only called on HTML page loads,
this would at least prevent to retrieve the user groups again and again with every XHR request
and this way reduce db queries massively as long as the user stays on the same page. :)

[lianglee]

This is much better method really nice 👍🏻