Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Many missing Property Sets #1299

Closed
Chris-12 opened this issue Jun 20, 2023 · 6 comments
Closed

Many missing Property Sets #1299

Chris-12 opened this issue Jun 20, 2023 · 6 comments

Comments

@Chris-12
Copy link

Hi,
In bimviews, and also in our javascript client, with a IF4 model, there are many missing Property Sets.

Even if we use query to perform the load of all of them with :
{
"type": {
"name": "IfcProduct",
"includeAllSubTypes": true
}}

As a comparison, in another program called BimVision (not a server but standalone) we get all of expected property sets :
Bim Vision -> OpenSource BIM Server:
Element Specific ->IfcBuildingElementProxy
Profile -> missing !
Constraints -> Constraints
Data -> missing !
Dimensions -> Dimensions
Electrical - Loads -> missing !
Identity Data -> missing !
Other -> Other
Phasing -> Phasing (but missing properties e.g. "4D_ID")

We are running last release: bimserverwar 184.
Is there a way to load all these missing property sets at client level (at preload time query, or else), or else ?
Regards,
Chris

@hlg
Copy link
Member

hlg commented Jun 20, 2023

Can you share a (perhaps minimal) IFC sample with the properties that are missing such that we can reproduce it in BIMvie.ws? Also: where are the properties missing - when browsing in BIMvie.ws, when downloading via query, in the properties tab or somewhere else?

@Chris-12
Copy link
Author

Yes it can be viewed, but the model is private. I sent you a mail for you to download the model from our private storage.
The missing properties are in the property panel of BIMvie.ws via query and also after downloading the model with the API.

@hlg
Copy link
Member

hlg commented Jun 28, 2023

Did you send the download link to bimserver@opensourcebim.org?

@Chris-12
Copy link
Author

Right, I did not use the correct address . Now I did.

@hlg
Copy link
Member

hlg commented Jul 12, 2023

Thank you for the file. I don't see any properties missing. The following query retreives all property sets including their properties as well as the objects and type objects they are assigned to and in case of type objects also the related type instances. It should include the property sets you mentioned above.

{ "type": "IfcPropertySet",
  "include": {
    "type": "IfcPropertySet",
    "fields": ["HasProperties", "DefinesOccurrence", "DefinesType"],
    "include": {
      "type": {"name": "IfcTypeObject", "includeAllSubTypes": true},
	  "field": "Types",
	  "include": {
	    "type": "IfcRelDefinesByType",
	    "field": "RelatedObjects"
      }
    }
  }
}

When downloading the whole revision, for example as IFC again, you should also get all the property sets.

The above query works from the property set to the assigned object. But likewise you can go the other way round: For a given object or product you should be able to retrieve all assigned property sets (IfcObject.IsDefinedBy, IfcRelDefinesByProperties.RelatingPropertyDefinition). Note that some property sets are not assigned directly to the objects, but to their type objects. Thus you have to navigate to the type object (IfcObject.IsTypedBy, IfcRelDefinesByType.RelatingType) before retrieving the property sets using an attribute chain similar to the one for IfcObject.

Property sets assigned to type objects may also be the reason that some properties do not appear very obviously in BIMvie.ws. Other applications may handle this differently, but in BIMvie.ws' property panel you see only direct properties of selected objects. However, you can easly modify this or access the type objects' property sets in your own application or client. In BIMvie.ws, you can also use the "Browse" tab to navigate all entities in a project and assure yourself that all the properties are actually there.

Hope that helps.

@Chris-12
Copy link
Author

Hi,
it works fine with information you gave. Thanks a lot.

@hlg hlg closed this as completed Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants