Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate changes for a script #155

Open
romainphan opened this issue Feb 20, 2024 · 3 comments
Open

Integrate changes for a script #155

romainphan opened this issue Feb 20, 2024 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@romainphan
Copy link
Contributor

romainphan commented Feb 20, 2024

Example:
>>> H_pos = np.random.rand(24,64)
>>> H_neg = np.random.rand(24,64)
>>> linop = LinearRowSplit(H_pos,H_neg)

Is this correct ? or should each matri H_pos and H_neg be positive as follows:

Example:
>>> H = np.random.rand(24,64)
>>> H_pos[H > 0] = H[H > 0]
>>> H_neg[H < 0] = -H[H < 0]
>>> linop = LinearRowSplit(H_pos,H_neg)
@tbaudier

@romainphan romainphan added documentation Improvements or additions to documentation invalid This doesn't seem right labels Feb 20, 2024
@nducros
Copy link
Member

nducros commented Feb 21, 2024

I suggest to remove the class.

Following our discussion, the idea will be to merge the hspim branch in order to run this script

@romainphan
Copy link
Contributor Author

The class LinearRowSplit will be removed.

Concerning the merge, what exactly should be merged ?

@romainphan romainphan added enhancement New feature or request and removed documentation Improvements or additions to documentation invalid This doesn't seem right labels Feb 21, 2024
@nducros
Copy link
Member

nducros commented Feb 21, 2024

hspim with master such that this script runs.
(But not now!)

@romainphan romainphan changed the title meas.py / LinearRowSplit example not correct Integrate changes for a script Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants