Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1149 - malawi core login icon #1213

Closed
wants to merge 1 commit into from
Closed

Conversation

AbdulWahabMemon
Copy link
Contributor

@AbdulWahabMemon AbdulWahabMemon commented Apr 19, 2022

IMPORTANT: Where possible all PRs must be linked to a Github issue

Fixes #1149

Checklist

  • I have written Unit tests for any new feature(s) and edge cases for bug fixes
  • I have added any strings visible on UI components to the strings.xml file
  • I have updated the CHANGELOG.md file for any notable changes to the codebase
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the project's style guide
  • I have built and run the fhircore app to verify my change fixes the issue and/or does not break the app

@codecov
Copy link

codecov bot commented Apr 19, 2022

Codecov Report

Merging #1213 (8149c26) into main (5d69569) will increase coverage by 1.34%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #1213      +/-   ##
============================================
+ Coverage     73.33%   74.67%   +1.34%     
- Complexity      872     1320     +448     
============================================
  Files           155      226      +71     
  Lines          5520     8533    +3013     
  Branches        907     1384     +477     
============================================
+ Hits           4048     6372    +2324     
- Misses          835     1169     +334     
- Partials        637      992     +355     
Flag Coverage Δ
anc 77.13% <ø> (?)
eir 66.75% <ø> (ø)
engine 74.73% <ø> (ø)
quest 73.20% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...egister/fhircore/anc/ui/report/ReportFilterPage.kt 80.55% <0.00%> (ø)
...core/anc/ui/anccare/details/AncDetailsViewModel.kt 85.96% <0.00%> (ø)
...martregister/fhircore/anc/util/AncOverviewUtils.kt 77.77% <0.00%> (ø)
...smartregister/fhircore/anc/util/SearchExtension.kt 95.23% <0.00%> (ø)
.../ui/details/bmicompute/BmiQuestionnaireActivity.kt 60.37% <0.00%> (ø)
...fhircore/anc/ui/family/form/FamilyFormConstants.kt 0.00% <0.00%> (ø)
...ister/fhircore/anc/ui/report/ReportHomeActivity.kt 81.13% <0.00%> (ø)
...hircore/anc/ui/details/adapter/AllergiesAdapter.kt 100.00% <0.00%> (ø)
...nc/ui/anccare/encounters/EncounterListViewModel.kt 100.00% <0.00%> (ø)
...re/anc/ui/family/register/components/FamilyList.kt 0.00% <0.00%> (ø)
... and 61 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d69569...8149c26. Read the comment docs.

@ellykits
Copy link
Collaborator

I will be addressing this in this issue #1165

@ellykits
Copy link
Collaborator

Closing this.

@ellykits ellykits closed this Apr 20, 2022
@ellykits ellykits deleted the 1149_malawi_login_icon branch May 26, 2023 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Malawi Core] Rebuild MWCore app in Quest
2 participants