Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UX Questionnaire adjustments #2032

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

FikriMilano
Copy link
Collaborator

IMPORTANT: Where possible all PRs must be linked to a Github issue

Fixes #1974

Checklist

  • I have written Unit tests for any new feature(s) and edge cases for bug fixes
  • I have added any strings visible on UI components to the strings.xml file
  • I have updated the CHANGELOG.md file for any notable changes to the codebase
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the project's style guide
  • I have built and run the fhircore app to verify my change fixes the issue and/or does not break the app

@FikriMilano FikriMilano self-assigned this Feb 10, 2023
@FikriMilano FikriMilano added the Blocked Item is blocked by another prerequisite label Mar 28, 2023
@ellykits
Copy link
Collaborator

Any update on this PR @FikriMilano?

@FikriMilano
Copy link
Collaborator Author

hi @ellykits, sorry I haven't continue on this.
I was assigned on something else.

let me follow up w @f-odhiambo on the priority of this PR.

@HenryRae
Copy link

@FikriMilano some of the things not mentioned here might still stand. Feel free to reachout incase of any questions

Main comparison
image

Common issues, specs are off:

  1. App header: Background color, text & icon color, padding between elements, padding between app header navigation & scroll progress.
    image

  2. Input fields: input fields structure same as googles with slight styling differences e.g bigger text sizes. Rest of the input field components can be found in the main design system file
    image

  3. Submit button & container: button round edges, and text alignment, container padding and alignment.
    image

  4. Page padding/Margin left and right: as shown in first image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Blocked Item is blocked by another prerequisite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[UX] Adjustments and Updates to widgets on Questionnaire - SDC
4 participants