Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mw-core sdc update to v1.0.0-preview14.3-SNAPSHOT #2625

Merged
merged 4 commits into from
Jul 31, 2023

Conversation

evance-mose
Copy link

IMPORTANT: Where possible all PRs must be linked to a Github issue

Fixes #[issue number] or Closes #[issue number]

Engineer Checklist

  • I have written Unit tests for any new feature(s) and edge cases for bug fixes
  • I have added any strings visible on UI components to the strings.xml file
  • I have updated the CHANGELOG.md file for any notable changes to the codebase
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the project's style guide
  • I have built and run the FHIRCore app to verify my change fixes the issue and/or does not break the app
  • I have checked that this PR does NOT introduce breaking changes that require an update to Content and/or Configs? If it does add a sample here or a link to exactly what changes need to be made to the content.

Code Reviewer Checklist

  • I have verified Unit tests have been written for any new feature(s) and edge cases
  • I have verified any strings visible on UI components are in the strings.xml file
  • I have verifed the CHANGELOG.md file has any notable changes to the codebase
  • I have verified the solution has been implemented in a configurable and generic way for reuseable components
  • I have built and run the FHIRCore app to verify the change fixes the issue and/or does not break the app

@evance-mose evance-mose requested a review from LZRS July 27, 2023 14:21
@codecov
Copy link

codecov bot commented Jul 27, 2023

Codecov Report

Merging #2625 (fcc9dc2) into mwcore-dev (63aedca) will increase coverage by 0.4%.
The diff coverage is 100.0%.

Impacted file tree graph

@@              Coverage Diff               @@
##             mwcore-dev   #2625     +/-   ##
==============================================
+ Coverage          68.0%   68.4%   +0.4%     
- Complexity          900     902      +2     
==============================================
  Files               156     156             
  Lines              6997    6958     -39     
  Branches            998     996      -2     
==============================================
+ Hits               4758    4761      +3     
+ Misses             1610    1570     -40     
+ Partials            629     627      -2     
Flag Coverage Δ
engine 68.4% <100.0%> (+0.4%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...hircore/engine/util/extension/AndroidExtensions.kt 65.6% <ø> (+36.0%) ⬆️
...e/engine/ui/questionnaire/QuestionnaireActivity.kt 77.0% <100.0%> (+1.1%) ⬆️

@LZRS LZRS force-pushed the mwcore-sdc-v1.0.0-preview14.3-SNAPSHOT branch from 9d8ba4c to fcc9dc2 Compare July 29, 2023 03:19
@evance-mose evance-mose self-assigned this Jul 31, 2023
@evance-mose evance-mose merged commit 5e40d4c into mwcore-dev Jul 31, 2023
4 checks passed
@evance-mose evance-mose deleted the mwcore-sdc-v1.0.0-preview14.3-SNAPSHOT branch July 31, 2023 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants