0.2.5 - Add Location Coordinates on Questionnaire Submission #3042
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Run spotlessApply
11 tasks
…old with extract location and list resources (#3131)
…rcore into questionnaire-location-0-2-5
dubdabasoduba
requested changes
Mar 13, 2024
| @@ -41,4 +41,5 @@ data class ApplicationConfiguration( | |||
| val showLogo: Boolean = true, | |||
| val taskBackgroundWorkerBatchSize: Int = 500, | |||
| val eventWorkflows: List<EventWorkflow> = emptyList(), | |||
| val logQuestionnaireLocation: Boolean = false, | |||
There was a problem hiding this comment.
Please match the architecture on the main PR. I think we have different configs there
Comment on lines
28
to
39
| var locationResourceCopy = locationResource | ||
|
|
||
| if (locationResourceCopy == null) { | ||
| locationResourceCopy = org.hl7.fhir.r4.model.Location() | ||
| } | ||
|
|
||
| locationResourceCopy.id = UUID.randomUUID().toString() | ||
| locationResourceCopy.position.latitude = gpsLocation!!.latitude.toBigDecimal() | ||
| locationResourceCopy.position.longitude = gpsLocation!!.longitude.toBigDecimal() | ||
| locationResourceCopy.position.altitude = gpsLocation!!.altitude.toBigDecimal() | ||
|
|
||
| return locationResourceCopy |
There was a problem hiding this comment.
Why are we creating a new object?
| .addOnSuccessListener { location: Location? -> | ||
| if (location != null) { | ||
| Timber.d( | ||
| "Approx location - lat: ${location.latitude}; long: ${location.longitude}; alt: ${location.altitude}", |
There was a problem hiding this comment.
Suggested change
| "Approx location - lat: ${location.latitude}; long: ${location.longitude}; alt: ${location.altitude}", | |
| "Approximate location - lat: ${location.latitude}; long: ${location.longitude}; alt: ${location.altitude}", |
- Refactor ResourceUtils
dubdabasoduba
approved these changes
Mar 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: Where possible all PRs must be linked to a Github issue
Fixes [link to issue]
Engineer Checklist
strings.xmlfile./gradlew spotlessApplyand./gradlew spotlessCheckto check my code follows the project's style guideCode Reviewer Checklist
strings.xmlfile