Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix setting related entity location on Group member and related resources #3092

Merged
merged 1 commit into from
Feb 22, 2024

Conversation

ellykits
Copy link
Collaborator

@ellykits ellykits commented Feb 22, 2024

IMPORTANT: Where possible all PRs must be linked to a Github issue

Fixes [link to issue]

Engineer Checklist

  • I have written Unit tests for any new feature(s) and edge cases for bug fixes
  • I have added any strings visible on UI components to the strings.xml file
  • I have updated the CHANGELOG.md file for any notable changes to the codebase
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the project's style guide
  • I have built and run the FHIRCore app to verify my change fixes the issue and/or does not break the app
  • I have checked that this PR does NOT introduce breaking changes that require an update to Content and/or Configs? If it does add a sample here or a link to exactly what changes need to be made to the content.

Code Reviewer Checklist

  • I have verified Unit tests have been written for any new feature(s) and edge cases
  • I have verified any strings visible on UI components are in the strings.xml file
  • I have verifed the CHANGELOG.md file has any notable changes to the codebase
  • I have verified the solution has been implemented in a configurable and generic way for reuseable components
  • I have built and run the FHIRCore app to verify the change fixes the issue and/or does not break the app

…rces

Signed-off-by: Elly Kitoto <junkmailstoelly@gmail.com>
Copy link

codecov bot commented Feb 22, 2024

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (ad3a737) 64.5% compared to head (b8d1d3b) 29.8%.
Report is 180 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              main   #3092      +/-   ##
==========================================
- Coverage     64.5%   29.8%   -34.7%     
+ Complexity    1075     652     -423     
==========================================
  Files          218     236      +18     
  Lines         9635   11059    +1424     
  Branches      1897    1925      +28     
==========================================
- Hits          6218    3306    -2912     
- Misses        2234    7323    +5089     
+ Partials      1183     430     -753     
Flag Coverage Δ
engine 66.2% <100.0%> (-6.5%) ⬇️
geowidget 47.2% <ø> (-17.1%) ⬇️
quest 5.3% <0.0%> (-53.7%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...ster/fhircore/engine/task/FhirCarePlanGenerator.kt 78.1% <100.0%> (+3.5%) ⬆️
...e/quest/ui/questionnaire/QuestionnaireViewModel.kt 3.5% <0.0%> (-69.7%) ⬇️

... and 125 files with indirect coverage changes

@pld pld merged commit 8e97b0e into main Feb 22, 2024
3 of 5 checks passed
@pld pld deleted the fix-adding-group-member-related-location-tag branch February 22, 2024 17:58
AbdulWahabMemon added a commit that referenced this pull request Feb 23, 2024
* main:
  add docs on tagging (#3089)
  Constrain isAAB option to Boolean type (#3093)
  Create manual-apk-release.yml (#3003)
  Fix setting related entity location on Group member and related resources (#3092)
  Enhance Image and ActionableButton Widget to add ability to copy text (#3040)
  Add Related entity location tag on newly created resources via configs (#3086)
  Spotless clean
  Fixes config resources flagged for upsync 🐛
  Clean up
AbdulWahabMemon added a commit that referenced this pull request Feb 23, 2024
* main:
  add docs on tagging (#3089)
  Constrain isAAB option to Boolean type (#3093)
  Create manual-apk-release.yml (#3003)
  Fix setting related entity location on Group member and related resources (#3092)
  Enhance Image and ActionableButton Widget to add ability to copy text (#3040)
  Add Related entity location tag on newly created resources via configs (#3086)
  Spotless clean
  Fixes config resources flagged for upsync 🐛
  Clean up
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants