-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement searchable multiselect widget #3123
Conversation
Start implementation on multi-select view. Includes the checkbox and listeners Signed-off-by: Elly Kitoto <junkmailstoelly@gmail.com>
Signed-off-by: Elly Kitoto <junkmailstoelly@gmail.com>
Signed-off-by: Elly Kitoto <junkmailstoelly@gmail.com>
Signed-off-by: Elly Kitoto <junkmailstoelly@gmail.com>
Drafted this PR to showcase the WIP for the new location selector UI |
This is not the complete UI, the rest of the work is still under active development. @dubdabasoduba verify the UX Screencast.from.03-05-2024.05.31.55.PM.webm |
This implementation should work with data from any Resource. The UI can also be partially customized. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3123 +/- ##
=========================================
- Coverage 29.6% 29.5% -0.2%
- Complexity 658 678 +20
=========================================
Files 239 247 +8
Lines 11204 11646 +442
Branches 1948 2021 +73
=========================================
+ Hits 3323 3441 +118
- Misses 7447 7756 +309
- Partials 434 449 +15
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Signed-off-by: Elly Kitoto <junkmailstoelly@gmail.com>
…opensrp/fhircore into implement-searchable-multiselect-widget
Signed-off-by: Elly Kitoto <junkmailstoelly@gmail.com>
Signed-off-by: Elly Kitoto <junkmailstoelly@gmail.com>
Signed-off-by: Elly Kitoto <junkmailstoelly@gmail.com>
Signed-off-by: Elly Kitoto <junkmailstoelly@gmail.com>
Use Tree data structure as required. Search Tree instead of searching the map. Render the UI from the Tree. Signed-off-by: Elly Kitoto <junkmailstoelly@gmail.com>
Hide keyboard when search action is triggered. Reset data when search text is empty. Signed-off-by: Elly Kitoto <junkmailstoelly@gmail.com>
Signed-off-by: Elly Kitoto <junkmailstoelly@gmail.com>
Also refactored how root nodes are identified. Use configuration instead of defaulting to a node without a parent node as the root node. Signed-off-by: Elly Kitoto <junkmailstoelly@gmail.com>
Add comma separated values for _syncLocations query parameter for all requests for the configured sync Resources. Signed-off-by: Elly Kitoto <junkmailstoelly@gmail.com>
Signed-off-by: Elly Kitoto <junkmailstoelly@gmail.com>
# Conflicts: # android/quest/src/main/java/org/smartregister/fhircore/quest/ui/register/RegisterViewModel.kt
android/engine/src/test/java/org/smartregister/fhircore/engine/sync/SyncListenerManagerTest.kt
Outdated
Show resolved
Hide resolved
Signed-off-by: Elly Kitoto <junkmailstoelly@gmail.com>
More tests to be added later, issue for tracking #3253 |
IMPORTANT: Where possible all PRs must be linked to a Github issue
Fixes #3068
Engineer Checklist
strings.xml
file./gradlew spotlessApply
and./gradlew spotlessCheck
to check my code follows the project's style guideCode Reviewer Checklist
strings.xml
file