Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configs Versioning #3189

Merged
merged 54 commits into from
May 6, 2024
Merged

Configs Versioning #3189

merged 54 commits into from
May 6, 2024

Conversation

hilpitome
Copy link
Contributor

@hilpitome hilpitome commented Apr 5, 2024

IMPORTANT: Where possible all PRs must be linked to a Github issue

Fixes #3150

Engineer Checklist

  • I have written Unit tests for any new feature(s) and edge cases for bug fixes
  • I have added any strings visible on UI components to the strings.xml file
  • I have updated the CHANGELOG.md file for any notable changes to the codebase
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the project's style guide
  • I have built and run the FHIRCore app to verify my change fixes the issue and/or does not break the app
  • I have checked that this PR does NOT introduce breaking changes that require an update to Content and/or Configs? If it does add a sample here or a link to exactly what changes need to be made to the content.

Code Reviewer Checklist

  • I have verified Unit tests have been written for any new feature(s) and edge cases
  • I have verified any strings visible on UI components are in the strings.xml file
  • I have verifed the CHANGELOG.md file has any notable changes to the codebase
  • I have verified the solution has been implemented in a configurable and generic way for reuseable components
  • I have built and run the FHIRCore app to verify the change fixes the issue and/or does not break the app

@hilpitome hilpitome added Draft Work In Progress Describes an items that is not complete. Mostly used for scoping issues of discussions labels Apr 5, 2024
Copy link

codecov bot commented Apr 5, 2024

Codecov Report

Attention: Patch coverage is 11.62791% with 38 lines in your changes are missing coverage. Please review.

Project coverage is 30.0%. Comparing base (ac82739) to head (0486c22).
Report is 37 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##              main   #3189     +/-   ##
=========================================
+ Coverage     29.6%   30.0%   +0.4%     
- Complexity     658     673     +15     
=========================================
  Files          239     239             
  Lines        11204   11293     +89     
  Branches      1948    1963     +15     
=========================================
+ Hits          3323    3395     +72     
- Misses        7447    7455      +8     
- Partials       434     443      +9     
Flag Coverage Δ
engine 66.5% <14.2%> (+0.3%) ⬆️
geowidget 47.2% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...hircore/engine/util/extension/ResourceExtension.kt 67.3% <0.0%> (+1.3%) ⬆️
...core/engine/configuration/ConfigurationRegistry.kt 65.5% <17.6%> (-2.6%) ⬇️
...hircore/quest/ui/appsetting/AppSettingViewModel.kt 2.1% <9.0%> (+0.5%) ⬆️

... and 5 files with indirect coverage changes

@qiarie qiarie marked this pull request as draft April 9, 2024 08:31
@qiarie qiarie changed the title 3150 configs versioning Configs Versioning Apr 9, 2024
@hilpitome hilpitome removed Draft Work In Progress Describes an items that is not complete. Mostly used for scoping issues of discussions labels Apr 29, 2024
@hilpitome hilpitome marked this pull request as ready for review April 29, 2024 08:46
@qiarie
Copy link
Contributor

qiarie commented Apr 29, 2024

@hilpitome Can we add some documentation on how to configure IGs?

@hilpitome
Copy link
Contributor Author

@hilpitome Can we add some documentation on how to configure IGs?

Yes, certainly

Copy link
Member

@pld pld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks pretty great, @hilpitome can you add more test coverage please to get it over the min?

Copy link
Member

@pld pld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hilpitome can you also start on the docs for this? you can make it a brief outline/placeholder then @qiarie and I will expand on it

pld
pld previously approved these changes May 3, 2024
@pld pld enabled auto-merge (squash) May 6, 2024 13:56
@pld pld merged commit 7882d96 into main May 6, 2024
4 of 5 checks passed
@pld pld deleted the 3150-configs-versioning branch May 6, 2024 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Support for ImplementationGuide to Define Resources Required by an App
4 participants