-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configs Versioning #3189
Configs Versioning #3189
Conversation
… into 3150-configs-versioning
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3189 +/- ##
=========================================
+ Coverage 29.6% 30.0% +0.4%
- Complexity 658 673 +15
=========================================
Files 239 239
Lines 11204 11293 +89
Branches 1948 1963 +15
=========================================
+ Hits 3323 3395 +72
- Misses 7447 7455 +8
- Partials 434 443 +9
Flags with carried forward coverage won't be shown. Click here to find out more.
|
- Add name field to IG config - Update variable name
@hilpitome Can we add some documentation on how to configure IGs? |
Yes, certainly |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this looks pretty great, @hilpitome can you add more test coverage please to get it over the min?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hilpitome can you also start on the docs for this? you can make it a brief outline/placeholder then @qiarie and I will expand on it
...oid/quest/src/main/java/org/smartregister/fhircore/quest/ui/usersetting/UserSettingScreen.kt
Outdated
Show resolved
Hide resolved
...id/quest/src/main/java/org/smartregister/fhircore/quest/ui/appsetting/AppSettingViewModel.kt
Outdated
Show resolved
Hide resolved
Co-authored-by: Peter Lubell-Doughtie <peter@ona.io>
… into 3150-configs-versioning
IMPORTANT: Where possible all PRs must be linked to a Github issue
Fixes #3150
Engineer Checklist
strings.xml
file./gradlew spotlessApply
and./gradlew spotlessCheck
to check my code follows the project's style guideCode Reviewer Checklist
strings.xml
file