Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new config to control the status icon size on Register screen #3219

Merged
merged 3 commits into from
May 14, 2024

Conversation

syedowaisali
Copy link
Contributor

…-size on register screen

IMPORTANT: Where possible all PRs must be linked to a Github issue

Fixes #3217

Engineer Checklist

  • I have written Unit tests for any new feature(s) and edge cases for bug fixes
  • I have added any strings visible on UI components to the strings.xml file
  • I have updated the CHANGELOG.md file for any notable changes to the codebase
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the project's style guide
  • I have built and run the FHIRCore app to verify my change fixes the issue and/or does not break the app
  • I have checked that this PR does NOT introduce breaking changes that require an update to Content and/or Configs? If it does add a sample here or a link to exactly what changes need to be made to the content.

Code Reviewer Checklist

  • I have verified Unit tests have been written for any new feature(s) and edge cases
  • I have verified any strings visible on UI components are in the strings.xml file
  • I have verifed the CHANGELOG.md file has any notable changes to the codebase
  • I have verified the solution has been implemented in a configurable and generic way for reuseable components
  • I have built and run the FHIRCore app to verify the change fixes the issue and/or does not break the app

Copy link

codecov bot commented Apr 30, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 29.3%. Comparing base (ac82739) to head (1444fad).
Report is 45 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##              main   #3219     +/-   ##
=========================================
- Coverage     29.6%   29.3%   -0.3%     
- Complexity     658     678     +20     
=========================================
  Files          239     248      +9     
  Lines        11204   11711    +507     
  Branches      1948    2042     +94     
=========================================
+ Hits          3323    3440    +117     
- Misses        7447    7822    +375     
- Partials       434     449     +15     
Flag Coverage Δ
engine 65.6% <100.0%> (-0.6%) ⬇️
geowidget 47.2% <ø> (ø)
quest 5.4% <0.0%> (+<0.1%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...core/engine/configuration/view/ButtonProperties.kt 86.5% <100.0%> (+0.2%) ⬆️
...fhircore/quest/ui/shared/components/ServiceCard.kt 0.0% <0.0%> (ø)

... and 7 files with indirect coverage changes

Copy link
Collaborator

@ellykits ellykits left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM @syedowaisali Fix the failing tests.

@ellykits ellykits merged commit b2adf6e into main May 14, 2024
4 of 5 checks passed
@ellykits ellykits deleted the issue-3217 branch May 14, 2024 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add new config to control the status icon size on Register screen
4 participants