Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the performer and organization info for consent resource along … #3230

Merged
merged 4 commits into from
Jul 18, 2024

Conversation

Aleem92
Copy link
Contributor

@Aleem92 Aleem92 commented May 2, 2024

…with unit tests (#3227)

IMPORTANT: Where possible all PRs must be linked to a Github issue

Fixes [link to issue]

Engineer Checklist

  • I have written Unit tests for any new feature(s) and edge cases for bug fixes
  • I have added any strings visible on UI components to the strings.xml file
  • I have updated the CHANGELOG.md file for any notable changes to the codebase
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the project's style guide
  • I have built and run the FHIRCore app to verify my change fixes the issue and/or does not break the app
  • I have checked that this PR does NOT introduce breaking changes that require an update to Content and/or Configs? If it does add a sample here or a link to exactly what changes need to be made to the content.

Code Reviewer Checklist

  • I have verified Unit tests have been written for any new feature(s) and edge cases
  • I have verified any strings visible on UI components are in the strings.xml file
  • I have verifed the CHANGELOG.md file has any notable changes to the codebase
  • I have verified the solution has been implemented in a configurable and generic way for reuseable components
  • I have built and run the FHIRCore app to verify the change fixes the issue and/or does not break the app

@Aleem92 Aleem92 requested a review from allan-on May 2, 2024 17:03
Copy link

codecov bot commented May 2, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 28.3%. Comparing base (83595aa) to head (0c8e9fa).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##              main   #3230     +/-   ##
=========================================
- Coverage     28.3%   28.3%   -0.1%     
  Complexity     716     716             
=========================================
  Files          266     266             
  Lines        12760   12764      +4     
  Branches      2265    2269      +4     
=========================================
+ Hits          3621    3622      +1     
- Misses        8666    8667      +1     
- Partials       473     475      +2     
Flag Coverage Δ
engine 64.9% <0.0%> (-0.1%) ⬇️
geowidget 19.8% <ø> (ø)
quest 4.8% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...hircore/engine/util/extension/ResourceExtension.kt 67.2% <0.0%> (-0.6%) ⬇️

@ellykits
Copy link
Collaborator

Fix the failing tests @Aleem92

…update

# Conflicts:
#	android/engine/src/test/java/org/smartregister/fhircore/engine/util/extension/ResourceExtensionTest.kt
#	android/quest/src/test/java/org/smartregister/fhircore/quest/ui/questionnaire/QuestionnaireViewModelTest.kt
Signed-off-by: Elly Kitoto <junkmailstoelly@gmail.com>
@ellykits ellykits merged commit 9ef20df into main Jul 18, 2024
4 of 5 checks passed
@ellykits ellykits deleted the performer_and_organization_info_for_consent_update branch July 18, 2024 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants