Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix questionnaire prepopulation using initialExpression #3240

Merged
merged 1 commit into from
May 8, 2024

Conversation

LZRS
Copy link
Contributor

@LZRS LZRS commented May 7, 2024

IMPORTANT: Where possible all PRs must be linked to a Github issue

Fixes #3237

Engineer Checklist

  • I have written Unit tests for any new feature(s) and edge cases for bug fixes
  • I have added any strings visible on UI components to the strings.xml file
  • I have updated the CHANGELOG.md file for any notable changes to the codebase
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the project's style guide
  • I have built and run the FHIRCore app to verify my change fixes the issue and/or does not break the app
  • I have checked that this PR does NOT introduce breaking changes that require an update to Content and/or Configs? If it does add a sample here or a link to exactly what changes need to be made to the content.

Code Reviewer Checklist

  • I have verified Unit tests have been written for any new feature(s) and edge cases
  • I have verified any strings visible on UI components are in the strings.xml file
  • I have verifed the CHANGELOG.md file has any notable changes to the codebase
  • I have verified the solution has been implemented in a configurable and generic way for reuseable components
  • I have built and run the FHIRCore app to verify the change fixes the issue and/or does not break the app

@LZRS LZRS added the bug-fix PR label for bug fix on release notes label May 7, 2024
@LZRS LZRS requested review from ellykits and Rkareko May 7, 2024 18:02
@LZRS LZRS self-assigned this May 7, 2024
Copy link

codecov bot commented May 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.5%. Comparing base (ac82739) to head (556d72c).
Report is 38 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              main   #3240      +/-   ##
==========================================
+ Coverage     29.6%   65.5%   +35.8%     
+ Complexity     658     599      -59     
==========================================
  Files          239     126     -113     
  Lines        11204    4596    -6608     
  Branches      1948     757    -1191     
==========================================
- Hits          3323    3013     -310     
+ Misses        7447    1199    -6248     
+ Partials       434     384      -50     
Flag Coverage Δ
engine 66.5% <ø> (+0.3%) ⬆️
geowidget 47.2% <ø> (ø)
quest ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 117 files with indirect coverage changes

@LZRS LZRS force-pushed the 3237-fix-initial-expressions branch from dd523e8 to 556d72c Compare May 8, 2024 09:48
@LZRS LZRS marked this pull request as ready for review May 8, 2024 11:14
@LZRS LZRS merged commit 86580cb into main May 8, 2024
5 checks passed
@LZRS LZRS deleted the 3237-fix-initial-expressions branch May 8, 2024 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug-fix PR label for bug fix on release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Default date of today using initialExpression failing in questionnaires
2 participants