Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CALCULATE_DISTANCE_RULE_EXECUTOR LocationLogOption to Application_Config #3276

Merged
merged 7 commits into from
May 28, 2024

Conversation

qiarie
Copy link
Contributor

@qiarie qiarie commented May 16, 2024

IMPORTANT: Where possible all PRs must be linked to a Github issue

Fixes #3274

Engineer Checklist

  • I have written Unit tests for any new feature(s) and edge cases for bug fixes
  • I have added any strings visible on UI components to the strings.xml file
  • I have updated the CHANGELOG.md file for any notable changes to the codebase
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the project's style guide
  • I have built and run the FHIRCore app to verify my change fixes the issue and/or does not break the app
  • I have checked that this PR does NOT introduce breaking changes that require an update to Content and/or Configs? If it does add a sample here or a link to exactly what changes need to be made to the content.

Code Reviewer Checklist

  • I have verified Unit tests have been written for any new feature(s) and edge cases
  • I have verified any strings visible on UI components are in the strings.xml file
  • I have verifed the CHANGELOG.md file has any notable changes to the codebase
  • I have verified the solution has been implemented in a configurable and generic way for reuseable components
  • I have built and run the FHIRCore app to verify the change fixes the issue and/or does not break the app

- Add check for LocationLogOptions entry to AppMainActivity's setupLocationServices
@qiarie qiarie requested review from Lentumunai-Mark, dubdabasoduba and ellykits and removed request for dubdabasoduba May 16, 2024 13:24
Copy link

codecov bot commented May 16, 2024

Codecov Report

Attention: Patch coverage is 25.00000% with 12 lines in your changes are missing coverage. Please review.

Project coverage is 28.0%. Comparing base (ac82739) to head (f302030).
Report is 64 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##              main   #3276     +/-   ##
=========================================
- Coverage     29.6%   28.0%   -1.7%     
- Complexity     658     690     +32     
=========================================
  Files          239     264     +25     
  Lines        11204   12398   +1194     
  Branches      1948    2164    +216     
=========================================
+ Hits          3323    3477    +154     
- Misses        7447    8462   +1015     
- Partials       434     459     +25     
Flag Coverage Δ
engine 64.9% <100.0%> (-1.4%) ⬇️
geowidget 18.7% <ø> (-28.5%) ⬇️
quest 5.2% <0.0%> (-0.2%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...gister/fhircore/engine/rulesengine/RulesFactory.kt 70.1% <100.0%> (+0.7%) ⬆️
...gister/fhircore/engine/util/SharedPreferenceKey.kt 100.0% <100.0%> (ø)
...register/fhircore/quest/ui/login/LoginViewModel.kt 1.6% <0.0%> (-0.1%) ⬇️
...register/fhircore/quest/ui/main/AppMainActivity.kt 1.3% <0.0%> (-1.1%) ⬇️

... and 11 files with indirect coverage changes

Copy link
Contributor

@Lentumunai-Mark Lentumunai-Mark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@pld pld enabled auto-merge (squash) May 21, 2024 15:46
@pld pld merged commit 1d82052 into main May 28, 2024
4 of 5 checks passed
@pld pld deleted the check-location-feature branch May 28, 2024 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Check for Distance Calculation Feature to Prevent Location Permissions Prompt for All Projects
3 participants