Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix app crash when navigation start destination is set to map #3331

Merged
merged 8 commits into from
Jun 20, 2024

Conversation

ellykits
Copy link
Collaborator

IMPORTANT: Where possible all PRs must be linked to a Github issue

Fixes [link to issue]

Engineer Checklist

  • I have written Unit tests for any new feature(s) and edge cases for bug fixes
  • I have added any strings visible on UI components to the strings.xml file
  • I have updated the CHANGELOG.md file for any notable changes to the codebase
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the project's style guide
  • I have built and run the FHIRCore app to verify my change fixes the issue and/or does not break the app
  • I have checked that this PR does NOT introduce breaking changes that require an update to Content and/or Configs? If it does add a sample here or a link to exactly what changes need to be made to the content.

Code Reviewer Checklist

  • I have verified Unit tests have been written for any new feature(s) and edge cases
  • I have verified any strings visible on UI components are in the strings.xml file
  • I have verifed the CHANGELOG.md file has any notable changes to the codebase
  • I have verified the solution has been implemented in a configurable and generic way for reuseable components
  • I have built and run the FHIRCore app to verify the change fixes the issue and/or does not break the app

Signed-off-by: Elly Kitoto <junkmailstoelly@gmail.com>
Copy link

codecov bot commented Jun 12, 2024

Codecov Report

Attention: Patch coverage is 0% with 39 lines in your changes missing coverage. Please review.

Project coverage is 28.2%. Comparing base (ac82739) to head (eff8bed).
Report is 94 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##              main   #3331     +/-   ##
=========================================
- Coverage     29.6%   28.2%   -1.5%     
- Complexity     658     719     +61     
=========================================
  Files          239     265     +26     
  Lines        11204   12688   +1484     
  Branches      1948    2258    +310     
=========================================
+ Hits          3323    3580    +257     
- Misses        7447    8639   +1192     
- Partials       434     469     +35     
Flag Coverage Δ
engine 64.8% <ø> (-1.4%) ⬇️
geowidget 18.3% <ø> (-28.9%) ⬇️
quest 4.8% <0.0%> (-0.6%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...e/quest/ui/questionnaire/QuestionnaireViewModel.kt 2.8% <0.0%> (-0.8%) ⬇️
...ore/quest/ui/launcher/GeoWidgetLauncherFragment.kt 0.0% <0.0%> (ø)
...register/fhircore/quest/ui/main/AppMainActivity.kt 0.0% <0.0%> (-2.5%) ⬇️

... and 25 files with indirect coverage changes

@ellykits ellykits marked this pull request as draft June 13, 2024 09:01
Signed-off-by: Elly Kitoto <junkmailstoelly@gmail.com>
Signed-off-by: Elly Kitoto <junkmailstoelly@gmail.com>
@ellykits ellykits marked this pull request as ready for review June 13, 2024 14:02
@ellykits ellykits changed the title Fix missing ID for navigation start destination Fix app crash when navigation start destination is set to map Jun 13, 2024
dubdabasoduba
dubdabasoduba previously approved these changes Jun 19, 2024
Signed-off-by: Elly Kitoto <junkmailstoelly@gmail.com>
@ellykits ellykits merged commit 742fdeb into main Jun 20, 2024
4 of 5 checks passed
@ellykits ellykits deleted the fix-launcher-type branch June 20, 2024 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants