Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download custom resources via sync configurations #3344

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

ellykits
Copy link
Collaborator

IMPORTANT: Where possible all PRs must be linked to a Github issue

Fixes #3308

Engineer Checklist

  • I have written Unit tests for any new feature(s) and edge cases for bug fixes
  • I have added any strings visible on UI components to the strings.xml file
  • I have updated the CHANGELOG.md file for any notable changes to the codebase
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the project's style guide
  • I have built and run the FHIRCore app to verify my change fixes the issue and/or does not break the app
  • I have checked that this PR does NOT introduce breaking changes that require an update to Content and/or Configs? If it does add a sample here or a link to exactly what changes need to be made to the content.

Code Reviewer Checklist

  • I have verified Unit tests have been written for any new feature(s) and edge cases
  • I have verified any strings visible on UI components are in the strings.xml file
  • I have verifed the CHANGELOG.md file has any notable changes to the codebase
  • I have verified the solution has been implemented in a configurable and generic way for reuseable components
  • I have built and run the FHIRCore app to verify the change fixes the issue and/or does not break the app

aurangzaibumer and others added 3 commits June 13, 2024 11:58
Signed-off-by: Elly Kitoto <junkmailstoelly@gmail.com>
Use sync configuration instead of relying on related resources declared
in Profile and Register configurations.

Signed-off-by: Elly Kitoto <junkmailstoelly@gmail.com>
Copy link

codecov bot commented Jun 19, 2024

Codecov Report

Attention: Patch coverage is 21.98582% with 110 lines in your changes missing coverage. Please review.

Project coverage is 27.6%. Comparing base (ac82739) to head (6fc9d66).
Report is 104 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##              main   #3344     +/-   ##
=========================================
- Coverage     29.6%   27.6%   -2.1%     
- Complexity     658     694     +36     
=========================================
  Files          239     266     +27     
  Lines        11204   12692   +1488     
  Branches      1948    2256    +308     
=========================================
+ Hits          3323    3508    +185     
- Misses        7447    8725   +1278     
- Partials       434     459     +25     
Flag Coverage Δ
engine 63.3% <23.1%> (-3.0%) ⬇️
geowidget 18.3% <ø> (-28.9%) ⬇️
quest 4.8% <0.0%> (-0.6%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...martregister/fhircore/engine/sync/AppSyncWorker.kt 91.6% <100.0%> (ø)
...ter/fhircore/engine/sync/OpenSrpDownloadManager.kt 42.8% <100.0%> (ø)
...gister/fhircore/engine/util/SharedPreferenceKey.kt 100.0% <ø> (ø)
...hircore/quest/ui/appsetting/AppSettingViewModel.kt 2.2% <ø> (+0.6%) ⬆️
...rcore/quest/ui/usersetting/UserSettingViewModel.kt 7.6% <0.0%> (-0.1%) ⬇️
...ore/quest/util/extensions/WorkManagerExtensions.kt 0.0% <0.0%> (ø)
...gister/fhircore/engine/sync/SyncListenerManager.kt 85.7% <0.0%> (-2.7%) ⬇️
...egister/fhircore/quest/ui/main/AppMainViewModel.kt 5.0% <0.0%> (+0.6%) ⬆️
...rtregister/fhircore/engine/sync/SyncBroadcaster.kt 0.0% <0.0%> (-15.3%) ⬇️
...tregister/fhircore/engine/sync/CustomSyncWorker.kt 0.0% <0.0%> (ø)
... and 1 more

... and 37 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FHIR Core] Add the ability to sync using the custom endpoints definition on the Sync Config
2 participants