Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate FHIR SDK Artifacts to latest #3376

Merged
merged 2 commits into from
Jul 9, 2024
Merged

Conversation

ndegwamartin
Copy link
Contributor

IMPORTANT: Where possible all PRs must be linked to a Github issue

Engineer Checklist

  • I have written Unit tests for any new feature(s) and edge cases for bug fixes
  • I have added any strings visible on UI components to the strings.xml file
  • I have updated the CHANGELOG.md file for any notable changes to the codebase
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the project's style guide
  • I have built and run the FHIRCore app to verify my change fixes the issue and/or does not break the app
  • I have checked that this PR does NOT introduce breaking changes that require an update to Content and/or Configs? If it does add a sample here or a link to exactly what changes need to be made to the content.

Code Reviewer Checklist

  • I have verified Unit tests have been written for any new feature(s) and edge cases
  • I have verified any strings visible on UI components are in the strings.xml file
  • I have verifed the CHANGELOG.md file has any notable changes to the codebase
  • I have verified the solution has been implemented in a configurable and generic way for reuseable components
  • I have built and run the FHIRCore app to verify the change fixes the issue and/or does not break the app

Copy link

codecov bot commented Jul 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 28.2%. Comparing base (09d764b) to head (816522f).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##              main   #3376   +/-   ##
=======================================
  Coverage     28.2%   28.2%           
  Complexity     720     720           
=======================================
  Files          265     265           
  Lines        12711   12712    +1     
  Branches      2261    2261           
=======================================
+ Hits          3596    3597    +1     
  Misses        8646    8646           
  Partials       469     469           
Flag Coverage Δ
engine 65.0% <100.0%> (+<0.1%) ⬆️
geowidget 18.3% <ø> (ø)
quest 4.8% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...core/engine/configuration/ConfigurationRegistry.kt 66.0% <100.0%> (+0.1%) ⬆️

dubdabasoduba
dubdabasoduba previously approved these changes Jul 9, 2024
@ndegwamartin ndegwamartin added this pull request to the merge queue Jul 9, 2024
@dubdabasoduba dubdabasoduba removed this pull request from the merge queue due to a manual request Jul 9, 2024
@dubdabasoduba dubdabasoduba added this pull request to the merge queue Jul 9, 2024
Merged via the queue into main with commit eb7471d Jul 9, 2024
7 checks passed
@dubdabasoduba dubdabasoduba deleted the migrate-fhir-sdk-2 branch July 9, 2024 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

i18N Bug: MLS for strings not picking special characters e.g. French Accents
2 participants