Added assertions on converters unit tests #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
githengi
reviewed
Jun 19, 2020
| questionnaireResponse.getItem().get(3).getAnswer().get(0).getValue().as(com.ibm.fhir.model.type.String.class) | ||
| .getValue(), event.getTeam()); | ||
| //TODO : Do we need to test individual obs, details and identifier fields? | ||
| System.out.println(questionnaireResponse); |
There was a problem hiding this comment.
Assert number of items created, also assert for 2 obs one with single value and one with several variables
githengi
reviewed
Jun 19, 2020
| assertEquals(fihrTask.getBasedOn().get(0).getReference().getValue(), task.getPlanIdentifier()); | ||
| assertEquals(fihrTask.getMeta().getVersionId().getValue(), String.valueOf(task.getServerVersion())); | ||
| assertEquals(fihrTask.getIntent().getValueAsEnumConstant().value(), "plan"); | ||
| //TODO: Do we need to add assertions for Notes individually? |
There was a problem hiding this comment.
You can test size of notes and one note is properly converted
githengi
reviewed
Jun 19, 2020
| assertEquals(patient.getIdentifier().size(),identifiersSize); | ||
| assertEquals(patient.getBirthDate().getValue().toString(),client.getBirthdate().toString("YYYY-MM-DD")); | ||
| assertEquals(patient.getDeceased().as(com.ibm.fhir.model.type.DateTime.class).getValue().toString(),client.getDeathdate().toString("yyyy-MM-dd'T'HH:mm'Z'")); | ||
| //TODO : Individual assertions on relationships, attributes and identifiers |
There was a problem hiding this comment.
Test number of size of relationships, attributes and identifiers converted is accurate and also assert one item from each category
githengi
suggested changes
Jun 22, 2020
githengi
reviewed
Jun 22, 2020
Comment on lines
112
to
119
| FHIRPathElementNode node = PathEvaluatorLibrary.getInstance().evaluateElementExpression(questionnaireResponse, "QuestionnaireResponse.item.where(linkId='totPopulation')"); | ||
| QuestionnaireResponse.Item totPopulation = node.element().as(QuestionnaireResponse.Item.class); | ||
| assertEquals(1,totPopulation.getAnswer().size()); | ||
| assertEquals(com.ibm.fhir.model.type.String.of("2"),totPopulation.getAnswer().get(0).getValue()); | ||
| node = PathEvaluatorLibrary.getInstance().evaluateElementExpression(questionnaireResponse, "QuestionnaireResponse.item.where(linkId='existingLLINs')"); | ||
|
|
||
| QuestionnaireResponse.Item existingLLINs = node.element().as(QuestionnaireResponse.Item.class); | ||
| assertEquals(2, existingLLINs.getAnswer().size()); //Test for multiple values |
There was a problem hiding this comment.
I have changed this instead of looping for all the items to use FHIRPath expressions to look up obs
githengi
reviewed
Jun 22, 2020
| assertEquals(patient.getDeceased().as(com.ibm.fhir.model.type.DateTime.class).getValue().toString(), | ||
| client.getDeathdate().toString("yyyy-MM-dd'T'HH:mm'Z'")); | ||
| for (Identifier identifier : patient.getIdentifier()) { | ||
| if (identifier.getSystem() != null && identifier.getSystem().getValue() |
There was a problem hiding this comment.
Use fhirpath expressions for lookup as if the identifier does not exist then test will fail. With this approach of looping tests will fail if identifiers don't exist
There was a problem hiding this comment.
githengi
approved these changes
Jun 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #26