Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore missing keys unless explicitly configured. #103

Closed
wants to merge 1 commit into from

Conversation

@dag-erling
Copy link
Contributor

commented Oct 9, 2018

When adding a host key file to the list, if file refers to our "[default]" constant and path does not exist, ignore it. This silences warnings on systems where certain keys are intentionally not present without requiring the administrator to explicitly list those that are. We will still get an error if no keys were found at all.

djmdjm added a commit to djmdjm/openbsd-openssh-src that referenced this pull request Nov 19, 2018

silence (to log level debug2) failure messages when loading the default
hostkeys. Hostkeys explicitly specified in the configuration or on
the command-line are still reported as errors, and failure to load at
least one host key remains a fatal error.

Based on patch from Dag-Erling Smørgrav via
openssh/openssh-portable#103

ok markus@

djmdjm added a commit that referenced this pull request Nov 19, 2018

upstream: silence (to log level debug2) failure messages when
loading the default hostkeys. Hostkeys explicitly specified in the
configuration or on the command-line are still reported as errors, and
failure to load at least one host key remains a fatal error.
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Based on patch from Dag-Erling Smørgrav via
#103

ok markus@

OpenBSD-Commit-ID: ffc2e35a75d1008effaf05a5e27425041c27b684
@djmdjm

This comment has been minimized.

Copy link
Contributor

commented Nov 19, 2018

Similar patch applied in 928f123

@djmdjm djmdjm closed this Nov 19, 2018

bob-beck pushed a commit to openbsd/src that referenced this pull request Nov 19, 2018

silence (to log level debug2) failure messages when loading the default
hostkeys. Hostkeys explicitly specified in the configuration or on
the command-line are still reported as errors, and failure to load at
least one host key remains a fatal error.

Based on patch from Dag-Erling Smørgrav via
openssh/openssh-portable#103

ok markus@
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.