Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for Time based Rekeying not getting trigered when no package is t… #373

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sanjeet-karan-singh
Copy link

Rekeying was not working until a package is received or sent.
The check to ensure packets are more than 0, before rekey timeout check was preventing rekey to occur, even though it reached timeout.

@sanjeet-karan-singh
Copy link
Author

sanjeet-karan-singh commented Jan 26, 2023

@daztucker / @djmdjm , Not sure why CI is failing. Can it be something environmental (something with CI) ?

@daztucker
Copy link
Contributor

There were two sets of failures both with the connection-timeout test:

  1. the test uses ControlMaster muxing which uses descriptor passing over Unix domain sockets. That's not supported on (at least) Cygwin. We now skip that test if configure decides FD passing isn't supported.
  2. Valgrind slows things down enough that it messed up the expected timing on the connect-timeout test. This one is probably fixable, but my quick attempt at it failed, so for now we skip that test when testing with Valgrind.

Both of these things have been committed, so if you rebase you should see those tests pass.

…ransfered

Rekeying was not working until a package is received or sent.
@sanjeet-karan-singh
Copy link
Author

sanjeet-karan-singh commented Feb 3, 2023

Thanks @daztucker / @djmdjm , just rebased. Can you please review changes.
Sorry, I'm not sure what's procedure for requesting merge of PR.

@sanjeet-karan-singh sanjeet-karan-singh marked this pull request as draft March 31, 2023 00:53
@sanjeet-karan-singh sanjeet-karan-singh marked this pull request as ready for review March 31, 2023 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants