do_fingerprint: reset comment = NULL in each line #407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When running `ssh-keygen -l` on an input file that contains both public keys with and without comment, then the indicator "no comment" never appears again after the first comment. This is because in `do_fingerprint()` the variable `comment` is initialized to NULL only at the start of the function, but must actually be re-initialized for each line read. Demonstration of this bug: $ cat bug ssh-ed25519 AAAAC3NzaC1lZDI1NTE5AAAAIBfpSaasTV3FbT+Ak92X5qL1UF3Nl0CPwWF/H3m/bBci ssh-ed25519 AAAAC3NzaC1lZDI1NTE5AAAAIJ2rupphYfNkBJvdPCHcnBd/5Gq/VbQ+1VgvriXW1Oyp foo@bar ssh-ed25519 AAAAC3NzaC1lZDI1NTE5AAAAIE5zBpiRVC+ORSiXsyHdbi0adLR4eYVa1I8i2Kpu+cRZ Expected behaviour: $ ssh-keygen -l -f bug 256 SHA256:Rj/1gp8XmwdtWhcS46y8nC8d8fMYxhVuoqQ9y22goJk no comment (ED25519) 256 SHA256:tqCk14afznT2VHNkBPG3T8xtbPhd4Z/yNAcSWloX2Nw foo@bar (ED25519) 256 SHA256:cpUGYGuJjZ5tVYv02Mq+wFDtATo9O8vlPqoHsl3tako no comment (ED25519) Actual behaviour: $ ssh-keygen -l -f bug 256 SHA256:Rj/1gp8XmwdtWhcS46y8nC8d8fMYxhVuoqQ9y22goJk no comment (ED25519) 256 SHA256:tqCk14afznT2VHNkBPG3T8xtbPhd4Z/yNAcSWloX2Nw foo@bar (ED25519) 256 SHA256:cpUGYGuJjZ5tVYv02Mq+wFDtATo9O8vlPqoHsl3tako (ED25519) "no comment" is missing in the last line of output.
|
Applied upstream and merged back as b4ac435 - thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running
ssh-keygen -lon an input file that contains bothpublic keys with and without comment, then the indicator "no comment"
never appears again after the first comment. This is because in
do_fingerprint()the variablecommentis initialized to NULL onlyat the start of the function, but must actually be re-initialized for
each line read.
Demonstration of this bug:
Expected behaviour:
Actual behaviour:
"no comment" is missing in the last line of output.