Modify the commit workflow to allow some unrecorded reviews #48
Conversation
levitte
force-pushed
the
commit-workflow-automaton-exceptions
branch
from
c6e6f18
to
bb8e360
Compare
This is connected to the effort to have releases being staged automatically. The automaton that performs this sort of staging cannot know who's going to be the reviewer, so our previous habit of pre-setting the commits with the intended reviewer is not possible to do any more, and changing them later with addrev would remove any signature the automaton adds, for example on the release tag. We therefore need to make an exception with such commits. Fixes openssl#49
levitte
force-pushed
the
commit-workflow-automaton-exceptions
branch
from
bb8e360
to
84b03d9
Compare
|
Okie, if there are no further comments, I'll start the vote tomorrow |
|
Opening vote (this post to be edited as votes come in) |
levitte
added
the
ready to vote
|
+1 |
|
I'm ok with this change as far as it goes - but is it sufficient?, i.e. this text remains unchanged:
The change in this PR only says that the review is done by "other means" and we don't record it in the commits. It doesn't remove the need for it to be reviewed and approved by at least two committers one of whom must also be an OTC member. Is the plan that the review will still take place...but just after the commits have been made? Anyway, as I said, I'm ok with this change as far as it goes: +1 |
|
+1 |
|
+1 |
|
[Vote +1] |
|
Closing vote with the current result: Accepted: yes (for: 5, against: 0, abstained: 0, not yet voted: 1) |
|
Modification merged, along with a record of the vote as it currently stands |
|
Voting +1 |
This is connected to the effort to have releases being staged automatically.
The automaton that performs this sort of staging cannot know who's going to
be the reviewer, so our previous habit of pre-setting the commits with the
intended reviewer is not possible to do any more, and changing them later
with addrev would remove any signature the automaton adds, for example on
the release tag.
We therefore need to make an exception with such commits.
Fixes #49