Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more clarity on when the urgent label can be applied #53

Closed
wants to merge 2 commits into from
Closed

Add more clarity on when the urgent label can be applied #53

wants to merge 2 commits into from

Conversation

mattcaswell
Copy link
Member

We should only be using "urgent" if the break was within that last 72 hours, i.e. not for something that has been broken for weeks.

@mattcaswell
Add more clarity on when the urgent label can be applied
537070f 
We should only be using "urgent" if the break was within that last 72
hours, i.e. not for something that has been broken for weeks.
@mattcaswell mattcaswell added the policy change A change to a policy is being proposed label Sep 12, 2023
tom-cosgrove-arm
tom-cosgrove-arm approved these changes Sep 12, 2023
View reviewed changes
Copy link
Contributor

@tom-cosgrove-arm tom-cosgrove-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

t8m
t8m reviewed Sep 12, 2023
View reviewed changes
policies/committer-policy.md Outdated Show resolved Hide resolved
@arapov
Copy link
Member

arapov commented Sep 12, 2023

LGTM.

slontis
slontis reviewed Sep 12, 2023
View reviewed changes
Copy link
Member

@slontis slontis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wording seems fine to me.

@mattcaswell
Copy link
Member Author

Fixup pushed incorporating the suggested wording updates. Please take another look.

tom-cosgrove-arm
tom-cosgrove-arm approved these changes Sep 13, 2023
View reviewed changes
Copy link
Contributor

@tom-cosgrove-arm tom-cosgrove-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

levitte
levitte approved these changes Sep 13, 2023
View reviewed changes
Copy link
Member

@levitte levitte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@t8m t8m added the ready to vote The policy change proposal is ready to be voted on by OMC label Oct 18, 2023
@levitte
Copy link
Member

levitte commented Oct 18, 2023

Vote: +1

@mattcaswell
Copy link
Member Author

I'm calling this PR to OMC vote:

As per the recommendation of the Working Group, the OMC to accept the change to the committer policy in PR#53 as of commit a762499

@mattcaswell
Copy link
Member Author

Vote [+1]

1 similar comment
@arapov
Copy link
Member

arapov commented Oct 18, 2023

Vote [+1]

@kroeckx
Copy link
Member

kroeckx commented Oct 18, 2023 via email

@t-j-h
Copy link
Member

t-j-h commented Oct 20, 2023

Vote: +1

1 similar comment
@paulidale
Copy link
Contributor

Vote: +1

@mattcaswell
Copy link
Member Author

The vote was closed and passed:

Topic: As per the recommendation of the Working Group, the OMC to accept the
       change to the committer policy in PR#53 as of commit a762499
Proposed by: Matt
Issue link: https://github.com/openssl/general-policies/pull/53
Public: yes
Opened: 2023-10-18
Closed: 2023-11-01
Accepted:  yes  (for: 5, against: 0, abstained: 0, not voted: 1)

  Anton      [+1]
  Kurt       [+1]
  Matt       [+1]
  Pauli      [+1]
  Richard    [  ]
  Tim        [+1]

Pushed.

@mattcaswell mattcaswell closed this Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t8m t8m t8m left review comments

@slontis slontis slontis left review comments

@levitte levitte levitte approved these changes

@tom-cosgrove-arm tom-cosgrove-arm tom-cosgrove-arm approved these changes

Assignees
No one assigned
Labels
policy change A change to a policy is being proposed ready to vote The policy change proposal is ready to be voted on by OMC
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@mattcaswell @arapov @levitte @kroeckx @t-j-h @paulidale @t8m @slontis @tom-cosgrove-arm