Add env variables to windows installer #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
Set the OPENSSL_CONF/CTLOG_FILE/SSL_CERT_FILE env vars during install to point to the proper installation directory also set a global OPENSSLDIR registry key in the non-user writeable keyspace to allow for a runtime defined fallback location that openssl can query at run time
Don't have the installer write the environment values anymore, as we don't want to overwrite previously set administrative values there Instead set the OPENSSLDIR ENGINESDIR and MODULESDIR values in the specific openssl key space that we expect in the openssl library
This was referenced Jun 27, 2024
We've decided that registry keys should be indexed by major.minor rather than major.minor.patch. Fix that up with this commit Also, since nsis doesn't do string replacements without the addition of a plugin (which I think we want to avoid using), we should pass in the version elements separately so they can be concatinated easily
levitte
requested changes
Jul 11, 2024
mattcaswell
requested changes
Jul 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add environment variable setting to the installer
this adds a selection screen to the installer, allows the root directory to be set for our various environment variables. It defaults to the 64 it binary path if included, and falls back to the 32 bit path otherwise, and can be overridden if a user wants to specify a shared directory