Skip to content

Commit

Permalink
Ensure we build ub sanitizer builds with -DPEDANTIC
Browse files Browse the repository at this point in the history
Otherwise we may get spurious results from ub sanitizer. For example we
assume we can tolerate some unaligned write without this define that ub
sanitizer will complain about.

Reviewed-by: Dmitry Belyavskiy <beldmit@gmail.com>
Reviewed-by: Paul Dale <pauli@openssl.org>
Reviewed-by: Hugo Landau <hlandau@openssl.org>
(Merged from #18983)

(cherry picked from commit 17b94de)
  • Loading branch information
mattcaswell authored and hlandau committed Aug 17, 2022
1 parent 9e4b57f commit 0f0634b
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
Expand Up @@ -144,7 +144,7 @@ jobs:
steps:
- uses: actions/checkout@v2
- name: config
run: ./config --banner=Configured --debug enable-asan enable-ubsan enable-rc5 enable-md2 enable-ec_nistp_64_gcc_128 enable-fips -DFUZZING_BUILD_MODE_UNSAFE_FOR_PRODUCTION && perl configdata.pm --dump
run: ./config --banner=Configured --debug enable-asan enable-ubsan enable-rc5 enable-md2 enable-ec_nistp_64_gcc_128 enable-fips -DFUZZING_BUILD_MODE_UNSAFE_FOR_PRODUCTION -DPEDANTIC && perl configdata.pm --dump
- name: make
run: make -s -j4
- name: make test
Expand Down

0 comments on commit 0f0634b

Please sign in to comment.