Skip to content

Commit

Permalink
Remove a redundant TODO
Browse files Browse the repository at this point in the history
If read_ahead data is left over when a record layer closes down, there is
already code present to push into the "next" BIO. So the TODO removed here
is no longer relevant.

Reviewed-by: Hugo Landau <hlandau@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from #18132)
  • Loading branch information
mattcaswell committed Aug 18, 2022
1 parent c77d455 commit 1b285ac
Showing 1 changed file with 0 additions and 4 deletions.
4 changes: 0 additions & 4 deletions ssl/record/methods/tls_common.c
Expand Up @@ -1080,10 +1080,6 @@ tls_int_new_record_layer(OSSL_LIB_CTX *libctx, const char *propq, int vers,
* that is destined for a higher protection level. To simplify the logic
* we don't support that at this stage.
*/
/*
* TODO(RECLAYER): Handle the case of read_ahead at the application
* level and a key update/reneg occurs.
*/
p = OSSL_PARAM_locate_const(options, OSSL_LIBSSL_RECORD_LAYER_PARAM_READ_AHEAD);
if (p != NULL && !OSSL_PARAM_get_int(p, &rl->read_ahead)) {
RLAYERfatal(rl, SSL_AD_INTERNAL_ERROR, SSL_R_FAILED_TO_GET_PARAMETER);
Expand Down

0 comments on commit 1b285ac

Please sign in to comment.