Skip to content

Commit

Permalink
DH: Make DH_bits(), DH_size(), and DH_security_bits() check that ther…
Browse files Browse the repository at this point in the history
…e are key parameters

Fixes #13569
Signed-off-by: Sahana Prasad <sahana@redhat.com>
  • Loading branch information
Sahana Prasad committed Jan 25, 2021
1 parent b897b35 commit 31fd062
Show file tree
Hide file tree
Showing 2 changed files with 15 additions and 6 deletions.
12 changes: 9 additions & 3 deletions crypto/dh/dh_lib.c
Expand Up @@ -187,12 +187,16 @@ void *DH_get_ex_data(const DH *d, int idx)

int DH_bits(const DH *dh)
{
return BN_num_bits(dh->params.p);
if (dh->params.p != NULL)
return BN_num_bits(dh->params.p);
return -1;
}

int DH_size(const DH *dh)
{
return BN_num_bytes(dh->params.p);
if (dh->params.p != NULL)
return BN_num_bytes(dh->params.p);
return -1;
}

int DH_security_bits(const DH *dh)
Expand All @@ -204,7 +208,9 @@ int DH_security_bits(const DH *dh)
N = dh->length;
else
N = -1;
return BN_security_bits(BN_num_bits(dh->params.p), N);
if (dh->params.p != NULL)
return BN_security_bits(BN_num_bits(dh->params.p), N);
return -1;
}

void DH_get0_pqg(const DH *dh,
Expand Down
9 changes: 6 additions & 3 deletions doc/man3/DH_size.pod
Expand Up @@ -38,11 +38,14 @@ key. See L<BN_security_bits(3)>.

=head1 RETURN VALUES

DH_bits() returns the number of bits in the key.
DH_bits() returns the number of bits in the key, or -1 if
B<dh> doesn't hold any key parameters.

DH_size() returns the prime size of Diffie-Hellman in bytes.
DH_size() returns the prime size of Diffie-Hellman in bytes, or -1 if
B<dh> doesn't hold any key parameters.

DH_security_bits() returns the number of security bits.
DH_security_bits() returns the number of security bits, or -1 if
B<dh> doesn't hold any key parameters.

=head1 SEE ALSO

Expand Down

0 comments on commit 31fd062

Please sign in to comment.