Skip to content

Commit

Permalink
QUIC CHANNEL: Clarify role of RX TPs in preparation of storing TX TPs
Browse files Browse the repository at this point in the history
Reviewed-by: Matt Caswell <matt@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from #20765)
  • Loading branch information
hlandau committed May 12, 2023
1 parent c6c0432 commit 54562e8
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 6 deletions.
6 changes: 3 additions & 3 deletions ssl/quic/quic_channel.c
Expand Up @@ -845,7 +845,7 @@ static int ch_on_transport_params(const unsigned char *params,
* This is correct; the BIDI_LOCAL TP governs streams created by
* the endpoint which sends the TP, i.e., our peer.
*/
ch->init_max_stream_data_bidi_remote = v;
ch->rx_init_max_stream_data_bidi_remote = v;
got_initial_max_stream_data_bidi_local = 1;
break;

Expand All @@ -865,7 +865,7 @@ static int ch_on_transport_params(const unsigned char *params,
* This is correct; the BIDI_REMOTE TP governs streams created
* by the endpoint which receives the TP, i.e., us.
*/
ch->init_max_stream_data_bidi_local = v;
ch->rx_init_max_stream_data_bidi_local = v;

/* Apply to stream 0. */
ossl_quic_txfc_bump_cwm(&ch->stream0->txfc, v);
Expand All @@ -884,7 +884,7 @@ static int ch_on_transport_params(const unsigned char *params,
goto malformed;
}

ch->init_max_stream_data_uni_remote = v;
ch->rx_init_max_stream_data_uni_remote = v;
got_initial_max_stream_data_uni = 1;
break;

Expand Down
6 changes: 3 additions & 3 deletions ssl/quic/quic_channel_local.h
Expand Up @@ -124,9 +124,9 @@ struct quic_channel_st {
QUIC_CONN_ID cur_local_dcid;

/* Transport parameter values received from server. */
uint64_t init_max_stream_data_bidi_local;
uint64_t init_max_stream_data_bidi_remote;
uint64_t init_max_stream_data_uni_remote;
uint64_t rx_init_max_stream_data_bidi_local;
uint64_t rx_init_max_stream_data_bidi_remote;
uint64_t rx_init_max_stream_data_uni_remote;
uint64_t rx_max_ack_delay; /* ms */
unsigned char rx_ack_delay_exp;

Expand Down

0 comments on commit 54562e8

Please sign in to comment.