Skip to content

Commit

Permalink
Fix quotes install_fips in Configurations/windows-makefile.tmpl
Browse files Browse the repository at this point in the history
Directories and file names with spaces require quoting...  again

Fixes #18880

Reviewed-by: Tomas Mraz <tomas@openssl.org>
Reviewed-by: Matt Caswell <matt@openssl.org>
Reviewed-by: Paul Dale <pauli@openssl.org>
Reviewed-by: Hugo Landau <hlandau@openssl.org>
(Merged from #18881)
  • Loading branch information
levitte authored and hlandau committed Jul 28, 2022
1 parent 67c0460 commit 709651c
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions Configurations/windows-makefile.tmpl
Expand Up @@ -500,8 +500,8 @@ uninstall_docs: uninstall_html_docs
{- output_off() if $disabled{fips}; "" -}
install_fips: build_sw $(INSTALL_FIPSMODULECONF)
# @[ -n "$(INSTALLTOP)" ] || (echo INSTALLTOP should not be empty; exit 1)
@$(PERL) $(SRCDIR)\util\mkdir-p.pl $(MODULESDIR)
@$(PERL) $(SRCDIR)\util\mkdir-p.pl $(OPENSSLDIR)
@"$(PERL)" "$(SRCDIR)\util\mkdir-p.pl" "$(MODULESDIR)"
@"$(PERL)" "$(SRCDIR)\util\mkdir-p.pl" "$(OPENSSLDIR)"
@$(ECHO) "*** Installing FIPS module"
@$(ECHO) "install $(INSTALL_FIPSMODULE) -> $(MODULESDIR)\$(FIPSMODULENAME)"
@"$(PERL)" "$(SRCDIR)\util\copy.pl" "$(INSTALL_FIPSMODULE)" "$(MODULESDIR)"
Expand Down

2 comments on commit 709651c

@robmcgee-mag
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, I noticed this in 3.0.5 and was about to fix it myself.
Possibly worth backporting unless you'll be releasing again soon.

@t8m
Copy link
Member

@t8m t8m commented on 709651c Aug 15, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fix is on 3.0 branch as well.

Please sign in to comment.