When requeueing deferred URXEs retain the order

If a URXE cannot be processed yet then we add it to the urx_deferred list. Later, when they can be processed, we requeue them in the urx_pending list. We must not reverse the order when doing so. We want to process the URXEs in the order that they were received. Reviewed-by: Hugo Landau <hlandau@openssl.org> Reviewed-by: Paul Dale <pauli@openssl.org> Reviewed-by: Todd Short <todd.short@me.com> Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from #22452)
openssl · Oct 24, 2023 · 86e11b1 · 86e11b1
1 parent acf9512
commit 86e11b1
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 15 deletions.
diff --git a/ssl/quic/quic_record_rx.c b/ssl/quic/quic_record_rx.c
@@ -280,7 +280,7 @@ static void qrx_requeue_deferred(OSSL_QRX *qrx)
 
     while ((e = ossl_list_urxe_head(&qrx->urx_deferred)) != NULL) {
         ossl_list_urxe_remove(&qrx->urx_deferred, e);
-        ossl_list_urxe_insert_head(&qrx->urx_pending, e);
+        ossl_list_urxe_insert_tail(&qrx->urx_pending, e);
     }
 }
 

diff --git a/test/recipes/75-test_quicapi_data/ssltraceref-zlib.txt b/test/recipes/75-test_quicapi_data/ssltraceref-zlib.txt
@@ -127,21 +127,21 @@ Received Packet
   Version: 0x00000001
   Destination Conn Id: <zero length id>
   Source Conn Id: 0x????????????????
-  Payload length: 213
-  Packet Number: 0x00000001
+  Payload length: 1042
+  Packet Number: 0x00000000
 Received Packet
   Packet Type: Handshake
   Version: 0x00000001
   Destination Conn Id: <zero length id>
   Source Conn Id: 0x????????????????
-  Payload length: 1042
-  Packet Number: 0x00000000
-Received Frame: Crypto
-    Offset: 1022
-    Len: 192
+  Payload length: 213
+  Packet Number: 0x00000001
 Received Frame: Crypto
     Offset: 0
     Len: 1022
+Received Frame: Crypto
+    Offset: 1022
+    Len: 192
 Received TLS Record
 Header:
   Version = TLS 1.2 (0x303)

diff --git a/test/recipes/75-test_quicapi_data/ssltraceref.txt b/test/recipes/75-test_quicapi_data/ssltraceref.txt
@@ -125,21 +125,21 @@ Received Packet
   Version: 0x00000001
   Destination Conn Id: <zero length id>
   Source Conn Id: 0x????????????????
-  Payload length: 213
-  Packet Number: 0x00000001
+  Payload length: 1042
+  Packet Number: 0x00000000
 Received Packet
   Packet Type: Handshake
   Version: 0x00000001
   Destination Conn Id: <zero length id>
   Source Conn Id: 0x????????????????
-  Payload length: 1042
-  Packet Number: 0x00000000
-Received Frame: Crypto
-    Offset: 1022
-    Len: 192
+  Payload length: 213
+  Packet Number: 0x00000001
 Received Frame: Crypto
     Offset: 0
     Len: 1022
+Received Frame: Crypto
+    Offset: 1022
+    Len: 192
 Received TLS Record
 Header:
   Version = TLS 1.2 (0x303)