Skip to content

Commit

Permalink
Do not define L_ENDIAN (for now) when we guessed linux64-loongarch64
Browse files Browse the repository at this point in the history
In 160f489 I made L_ENDIAN defined when the system is guessed to be
linux64-loongarch64.  Unfortunately now I found it problematic:

1. This should be added into Configurations/10-main.conf, not here.
   Having it here causes a different configuration when
   linux64-loongarch64 is explicitly specified than guessed.
2. With LTO enabled, this causes many test failures on
   linux64-loongarch64 due to #12247.

So I think we should remove it for now (master and 3.2 branch), and
reintroduce it to Configurations/10-main.conf when we finally sort
out #12247.

Reviewed-by: Matt Caswell <matt@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from #22812)
  • Loading branch information
xry111 authored and t8m committed Nov 28, 2023
1 parent eadebcc commit d7c0fc5
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion util/perl/OpenSSL/config.pm
Original file line number Diff line number Diff line change
Expand Up @@ -691,7 +691,6 @@ EOF
$disable = [];
}
return { target => "linux64-loongarch64",
defines => [ 'L_ENDIAN' ],
disable => $disable, };
}
],
Expand Down

0 comments on commit d7c0fc5

Please sign in to comment.