Skip to content

Commit

Permalink
Add a test for no initialisation of the default config file
Browse files Browse the repository at this point in the history
Reviewed-by: Dmitry Belyavskiy <beldmit@gmail.com>
Reviewed-by: Paul Dale <pauli@openssl.org>
(Merged from #20341)

(cherry picked from commit 0aa7d7f)
  • Loading branch information
mattcaswell authored and paulidale committed Feb 21, 2023
1 parent ba8e207 commit ed8d2c9
Show file tree
Hide file tree
Showing 4 changed files with 98 additions and 1 deletion.
7 changes: 6 additions & 1 deletion test/build.info
Expand Up @@ -62,7 +62,8 @@ IF[{- !$disabled{tests} -}]
context_internal_test aesgcmtest params_test evp_pkey_dparams_test \
keymgmt_internal_test hexstr_test provider_status_test defltfips_test \
bio_readbuffer_test user_property_test pkcs7_test upcallstest \
provfetchtest prov_config_test rand_test fips_version_test
provfetchtest prov_config_test rand_test fips_version_test \
nodefltctxtest

IF[{- !$disabled{'deprecated-3.0'} -}]
PROGRAMS{noinst}=enginetest
Expand Down Expand Up @@ -214,6 +215,10 @@ IF[{- !$disabled{tests} -}]
INCLUDE[provider_status_test]=../include ../apps/include
DEPEND[provider_status_test]=../libcrypto.a libtestutil.a

SOURCE[nodefltctxtest]=nodefltctxtest.c
INCLUDE[nodefltctxtest]=../include ../apps/include
DEPEND[nodefltctxtest]=../libcrypto.a libtestutil.a

IF[{- !$disabled{'deprecated-3.0'} -}]
PROGRAMS{noinst}=igetest bftest casttest

Expand Down
60 changes: 60 additions & 0 deletions test/nodefltctxtest.c
@@ -0,0 +1,60 @@
/*
* Copyright 2023 The OpenSSL Project Authors. All Rights Reserved.
*
* Licensed under the Apache License 2.0 (the "License"). You may not use
* this file except in compliance with the License. You can obtain a copy
* in the file LICENSE in the source distribution or at
* https://www.openssl.org/source/license.html
*/

#include <openssl/evp.h>
#include "testutil.h"

/*
* Test that the default libctx does not get initialised when using a custom
* libctx. We assume that this test application has been executed such that the
* null provider is loaded via the config file.
*/
static int test_no_deflt_ctx_init(void)
{
int testresult = 0;
EVP_MD *md = NULL;
OSSL_LIB_CTX *ctx = OSSL_LIB_CTX_new();

if (!TEST_ptr(ctx))
return 0;

md = EVP_MD_fetch(ctx, "SHA2-256", NULL);
if (!TEST_ptr(md))
goto err;

/*
* Since we're using a non-default libctx above, the default libctx should
* not have been initialised via config file, and so it is not too late to
* use OPENSSL_INIT_NO_LOAD_CONFIG.
*/
OPENSSL_init_crypto(OPENSSL_INIT_NO_LOAD_CONFIG, NULL);

/*
* If the config file was incorrectly loaded then the null provider will
* have been initialised and the default provider loading will have been
* blocked. If the config file was NOT loaded (as we expect) then the
* default provider should be available.
*/
if (!TEST_true(OSSL_PROVIDER_available(NULL, "default")))
goto err;
if (!TEST_false(OSSL_PROVIDER_available(NULL, "null")))
goto err;

testresult = 1;
err:
EVP_MD_free(md);
OSSL_LIB_CTX_free(ctx);
return testresult;
}

int setup_tests(void)
{
ADD_TEST(test_no_deflt_ctx_init);
return 1;
}
13 changes: 13 additions & 0 deletions test/null.cnf
@@ -0,0 +1,13 @@
openssl_conf = openssl_init

# Comment out the next line to ignore configuration errors
config_diagnostics = 1

[openssl_init]
providers = provider_sect

[provider_sect]
null = null_sect

[null_sect]
activate = 1
19 changes: 19 additions & 0 deletions test/recipes/04-test_nodefltctx.t
@@ -0,0 +1,19 @@
#! /usr/bin/env perl
# Copyright 2023The OpenSSL Project Authors. All Rights Reserved.
#
# Licensed under the Apache License 2.0 (the "License"). You may not use
# this file except in compliance with the License. You can obtain a copy
# in the file LICENSE in the source distribution or at
# https://www.openssl.org/source/license.html

use strict;
use OpenSSL::Test::Simple;
use OpenSSL::Test qw/:DEFAULT srctop_file/;
use Cwd qw(abs_path);

setup("test_nodefltctx");

# Load the null provider by default into the default libctx
$ENV{OPENSSL_CONF} = abs_path(srctop_file("test", "null.cnf"));

simple_test("test_nodefltctx", "nodefltctxtest");

0 comments on commit ed8d2c9

Please sign in to comment.