Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

With master the genpkey -genparam command ignores the -pkeyopt dh_paramgen_type option #13956

Closed
t8m opened this issue Jan 25, 2021 · 6 comments
Closed

With master the genpkey -genparam command ignores the -pkeyopt dh_paramgen_type option #13956

t8m opened this issue Jan 25, 2021 · 6 comments
Assignees
@slontis
Labels
branch: master Merge to master branch triaged: bug The issue/pr is/fixes a bug triaged: OTC evaluated This issue/pr was triaged by OTC
Milestone
3.0.0 beta1

Comments

@t8m
Copy link
Member

t8m commented Jan 25, 2021

The dh_paramgen_type should indicate whether DH (value 0) or DHX (value 1) type of DH parameters are generated. This is ignored with current master and if DHX parameters are to be generated the -algorithm DHX must be used instead.
@t8m t8m added issue: bug report The issue was opened to report a bug branch: master Merge to master branch triaged: bug The issue/pr is/fixes a bug and removed issue: bug report The issue was opened to report a bug labels Jan 25, 2021
@t8m t8m added this to the 3.0.0 beta1 milestone Jan 25, 2021
@t8m t8m mentioned this issue Jan 25, 2021
Closed
@mattcaswell mattcaswell added the triaged: OTC evaluated This issue/pr was triaged by OTC label Jan 26, 2021
@slontis
Copy link
Member

slontis commented Feb 3, 2021

This is not quite correct.. The values in 1.1.1 are.
0 = DH param gen using generator
1 = DSA param gen using fips 186-2 converted to DHX
2 = DSA param gen using fips 186-3 converted to DHX

This command is telling it to create a DH algorithm and then it changes it to DHX..

@levitte
Copy link
Member

levitte commented Feb 3, 2021 •
edited

This is related to #13871 and #13952

@levitte levitte mentioned this issue Feb 3, 2021
Closed
@paulnelsontx paulnelsontx self-assigned this Feb 4, 2021
This was referenced Feb 11, 2021
Closed
Closed
@t8m t8m mentioned this issue Feb 22, 2021
Closed
@t8m t8m added triaged: documentation The issue/pr deals with documentation (errors) triaged: bug The issue/pr is/fixes a bug and removed triaged: bug The issue/pr is/fixes a bug triaged: documentation The issue/pr deals with documentation (errors) labels Apr 7, 2021
@mattcaswell mattcaswell self-assigned this Apr 7, 2021
@slontis
Copy link
Member

slontis commented Apr 13, 2021

@mattcaswell do you want me to look at this and all the other dh/dhx related issues?

@mattcaswell
Copy link
Member

do you want me to look at this and all the other dh/dhx related issues?

If you want to take them on, I'm more than happy for you to do that. I had this one and #14444 in my queue for the current sprint. If you want to take them I'll pick some other issues instead. Let me know if you want to do that.

@slontis
Copy link
Member

slontis commented Apr 13, 2021

do you want me to look at this and all the other dh/dhx related issues?

If you want to take them on, I'm more than happy for you to do that. I had this one and #14444 in my queue for the current sprint. If you want to take them I'll pick some other issues instead. Let me know if you want to do that.

Yep I can do that one too.. (14145,13956,13952,13871,14054,14444) are all kind of related.

@mattcaswell mattcaswell assigned slontis and unassigned mattcaswell Apr 13, 2021
@mattcaswell
Copy link
Member

Ok I reassigned this one and #14444 to you.

slontis added a commit to slontis/openssl that referenced this issue Apr 21, 2021
@slontis
Fix dh_rfc5114 option in genpkey.
89a0948 
Fixes openssl#14145
Fixes openssl#13956
Fixes openssl#13952
Fixes openssl#13871
Fixes openssl#14054
Fixes openssl#14444

Updated documentation for app to indicate what options are available for
DH and DHX keys.

DH and DHX now have different keymanager gen_set_params() methods.

Added CHANGES entry to indicate the breaking change.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@slontis slontis

Labels
branch: master Merge to master branch triaged: bug The issue/pr is/fixes a bug triaged: OTC evaluated This issue/pr was triaged by OTC
Projects
None yet
Milestone
3.0.0 beta1
Development

No branches or pull requests
5 participants
@levitte @t8m @mattcaswell @slontis @paulnelsontx