Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Master branch build is broken with enable-sctp option #19371

Closed
simo5 opened this issue Oct 10, 2022 · 1 comment
Closed

Master branch build is broken with enable-sctp option #19371

simo5 opened this issue Oct 10, 2022 · 1 comment
Labels
branch: master Merge to master branch triaged: bug The issue/pr is/fixes a bug

Comments

@simo5
Copy link
Contributor

simo5 commented Oct 10, 2022

I built it this way:

./Configure --prefix=$HOME/tmp/openssl --openssldir=/etc/pki/tls \
    zlib enable-rfc3779 enable-sctp enable-cms no-mdc2 no-ec2m no-sm2 no-sm4 \
    enable-buildtest-c++ shared '-DDEVRANDOM="\"/dev/urandom\""'
make all

and the build breaks this way:

[..]
gcc  -I. -Iinclude  -DAES_ASM -fPIC -pthread -m64 -Wa,--noexecstack -Wall -O3 -DOPENSSL_USE_NODELETE -DL_ENDIAN -DOPENSSL_PIC -DOPENSSLDIR="\"/etc/pki/tls\"" -DENGINESDIR="\"/home/tmp/openssl/lib64/engines-3\"" -DMODULESDIR="\"/home/tmp/openssl/lib64/ossl-modules\"" -DOPENSSL_BUILDING_OPENSSL -DZLIB -DNDEBUG -DDEVRANDOM="\"/dev/urandom\"" -MMD -MF ssl/record/libssl-lib-rec_layer_d1.d.tmp -MT ssl/record/libssl-lib-rec_layer_d1.o -c -o ssl/record/libssl-lib-rec_layer_d1.o ssl/record/rec_layer_d1.c
ssl/record/rec_layer_d1.c: In function 'dtls_buffer_record':
ssl/record/rec_layer_d1.c:140:40: error: 'ssl' undeclared (first use in this function)
  140 |     if (BIO_dgram_is_sctp(SSL_get_rbio(ssl)) &&
      |                                        ^~~
ssl/record/rec_layer_d1.c:140:40: note: each undeclared identifier is reported only once for each function it appears in
ssl/record/rec_layer_d1.c: In function 'dtls_unbuffer_record':
ssl/record/rec_layer_d1.c:178:44: warning: passing argument 1 of 'SSL_get_rbio' from incompatible pointer type [-Wincompatible-pointer-types]
  178 |         if (BIO_dgram_is_sctp(SSL_get_rbio(s))) {
      |                                            ^
      |                                            |
      |                                            SSL_CONNECTION * {aka struct ssl_connection_st *}
In file included from ssl/record/../ssl_local.h:26,
                 from ssl/record/rec_layer_d1.c:12:
include/openssl/ssl.h:1655:37: note: expected 'const SSL *' {aka 'const struct ssl_st *'} but argument is of type 'SSL_CONNECTION *' {aka 'struct ssl_connection_st *'}
 1655 | __owur BIO *SSL_get_rbio(const SSL *s);
      |                          ~~~~~~~~~~~^
ssl/record/rec_layer_d1.c:179:35: warning: passing argument 1 of 'SSL_get_rbio' from incompatible pointer type [-Wincompatible-pointer-types]
  179 |             BIO_ctrl(SSL_get_rbio(s), BIO_CTRL_DGRAM_SCTP_SET_RCVINFO,
      |                                   ^
      |                                   |
      |                                   SSL_CONNECTION * {aka struct ssl_connection_st *}
include/openssl/ssl.h:1655:37: note: expected 'const SSL *' {aka 'const struct ssl_st *'} but argument is of type 'SSL_CONNECTION *' {aka 'struct ssl_connection_st *'}
 1655 | __owur BIO *SSL_get_rbio(const SSL *s);
      |                          ~~~~~~~~~~~^
make[1]: *** [Makefile:20315: ssl/record/libssl-lib-rec_layer_d1.o] Error 1
make[1]: Leaving directory '/home/devel/git/openssl'
make: *** [Makefile:3392: build_sw] Error 2

Like cause is commit eddb067

@simo5 simo5 added the issue: bug report The issue was opened to report a bug label Oct 10, 2022
@paulidale paulidale added triaged: bug The issue/pr is/fixes a bug and removed issue: bug report The issue was opened to report a bug labels Oct 10, 2022
@t8m
Copy link
Member

t8m commented Oct 11, 2022

See also eddb067#r86366751

@t8m t8m added the branch: master Merge to master branch label Oct 11, 2022
slontis added a commit to slontis/openssl that referenced this issue Oct 12, 2022
Fixes openssl#19371

running config with 'enable-sctp' gave compiler errors.
slontis added a commit to slontis/openssl that referenced this issue Oct 13, 2022
Fixes openssl#19371

running config with 'enable-sctp' gave compiler errors.
beldmit pushed a commit to beldmit/openssl that referenced this issue Dec 26, 2022
Fixes openssl#19371

running config with 'enable-sctp' gave compiler errors.

Reviewed-by: Tomas Mraz <tomas@openssl.org>
Reviewed-by: Matt Caswell <matt@openssl.org>
Reviewed-by: Hugo Landau <hlandau@openssl.org>
(Merged from openssl#19398)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch: master Merge to master branch triaged: bug The issue/pr is/fixes a bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants