Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

APPS do_X509_sign(): is it complete w.r.t. RFC 5280 compliance? #19805

Open
DDvO opened this issue Dec 1, 2022 · 1 comment
Open

APPS do_X509_sign(): is it complete w.r.t. RFC 5280 compliance? #19805

DDvO opened this issue Dec 1, 2022 · 1 comment
Labels
triaged: question The issue contains a question

Comments

@DDvO
Copy link
Contributor

DDvO commented Dec 1, 2022

Meanwhile, do_X509_sign() makes sure that, by default, subject key identifier (SKID) and issuer key identifier (AKID) are added as far as required by RFC 5280. I also makes sure that X.509 version 3 is set whenever X.509 extensions are included.

Is there anything else the function should do for ensuring RFC 5280 compliance for new certs by default?
@DDvO DDvO added the issue: question The issue was opened to ask a question label Dec 1, 2022
@DDvO
Copy link
Contributor Author

DDvO commented Dec 1, 2022

This is a spin-off from #16006.

@DDvO DDvO mentioned this issue Dec 1, 2022
Closed
@t8m t8m added triaged: question The issue contains a question and removed issue: question The issue was opened to ask a question labels Dec 1, 2022
DDvO added a commit to siemens/openssl that referenced this issue May 30, 2023
@DDvO
apps.c: add comment to do_X509_sign() referring to question openssl#1…
b2eaa9c 
…9805
openssl-machine pushed a commit that referenced this issue Jun 1, 2023
@DDvO
apps.c: add comment to do_X509_sign() referring to question #19805
586b540 
Reviewed-by: Paul Dale <pauli@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
Reviewed-by: David von Oheimb <david.von.oheimb@siemens.com>
(Merged from #21086)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
triaged: question The issue contains a question
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@DDvO @t8m