Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

genrsa is not really deprecated although documented so #21055

Closed
t8m opened this issue May 25, 2023 · 6 comments
Closed

genrsa is not really deprecated although documented so #21055

t8m opened this issue May 25, 2023 · 6 comments
Labels
branch: master Merge to master branch branch: 3.0 Merge to openssl-3.0 branch branch: 3.1 Merge to openssl-3.1 good first issue Bite size change that could be a good start triaged: bug The issue/pr is/fixes a bug triaged: documentation The issue/pr deals with documentation (errors)

Comments

@t8m
Copy link
Member

t8m commented May 25, 2023

The notice from openssl-genrsa(1) manpage should be removed.
@t8m t8m added branch: master Merge to master branch good first issue Bite size change that could be a good start triaged: bug The issue/pr is/fixes a bug triaged: documentation The issue/pr deals with documentation (errors) branch: 3.0 Merge to openssl-3.0 branch branch: 3.1 Merge to openssl-3.1 labels May 25, 2023
@Abdullah-03
Copy link
Contributor

I'll fix it and open a pull request.

@Abdullah-03
Copy link
Contributor

@t8m The history section of genrsa is only comprised of the statement: "This command was deprecated in OpenSSL 3.0.".

Removing it will make it so it will be empty. Is that fine or should something else be added there, if it is to be added then please let me know as I'm not versed enough to do so myself.

@t8m
Copy link
Member Author

t8m commented May 25, 2023

Replace the statement with This command was erroneously marked as deprecated in OpenSSL 3.0. It is not deprecated.

Abdullah-03 added a commit to Abdullah-03/openssl that referenced this issue May 25, 2023
@Abdullah-03
Fix documentation where openssl-genrsa is listed as
07db3a3 
deprecated since OpenSSL 3.0

openssl-genrsa is not deprecated however the OpenSSL documentation
states that it is the case from OpenSSL 3.0. This has been fixed in the
documentation, specifically in manpage 1.

Fixes openssl#21055

CLA: trivial
@Abdullah-03 Abdullah-03 mentioned this issue May 25, 2023
Closed
1 task
@paulidale
Copy link
Contributor

It was deprecated deliberately. The erroneously part isn't correct.

I do agree with keeping the command and undeprecating it.

@t8m
Copy link
Member Author

t8m commented May 26, 2023

@paulidale No, it was not deprecated. There was originally a decision to deprecate all these gendsa/dsa/rsa/genrsa and similar commands but none of them was in the end deprecated for good reasons. The only deprecated command that should stay deprecated that is related is the rsautl command.

@petrovr
Copy link

petrovr commented May 27, 2023 via email

Abdullah-03 added a commit to Abdullah-03/openssl that referenced this issue Jun 1, 2023
@Abdullah-03
History section from openssl-genrsa docs removed.
95bd485 
Fixes openssl#21055

CLA: trivial
openssl-machine pushed a commit that referenced this issue Jun 2, 2023
@Abdullah-03 @t8m
Fix documentation where openssl-genrsa is listed as deprecated since …
8e549ac 
…OpenSSL 3.0

openssl-genrsa is not deprecated however the OpenSSL documentation
states that it is the case from OpenSSL 3.0. This has been fixed in the
documentation, specifically in manpage 1.

Fixes #21055

CLA: trivial

Reviewed-by: Paul Dale <pauli@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from #21059)

(cherry picked from commit 4ad2dd4)
openssl-machine pushed a commit that referenced this issue Jun 2, 2023
@Abdullah-03 @t8m
Fix documentation where openssl-genrsa is listed as deprecated since …
9d4634d 
…OpenSSL 3.0

openssl-genrsa is not deprecated however the OpenSSL documentation
states that it is the case from OpenSSL 3.0. This has been fixed in the
documentation, specifically in manpage 1.

Fixes #21055

CLA: trivial

Reviewed-by: Paul Dale <pauli@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from #21059)

(cherry picked from commit 4ad2dd4)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
branch: master Merge to master branch branch: 3.0 Merge to openssl-3.0 branch branch: 3.1 Merge to openssl-3.1 good first issue Bite size change that could be a good start triaged: bug The issue/pr is/fixes a bug triaged: documentation The issue/pr deals with documentation (errors)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix documentation where openssl-genrsa is listed as deprecated since OpenSSL 3.0 Abdullah-03/openssl
4 participants
@petrovr @t8m @paulidale @Abdullah-03