Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provider compatibility across versions CI needs fixes #21134

Closed
t8m opened this issue Jun 6, 2023 · 4 comments
Closed

Provider compatibility across versions CI needs fixes #21134

t8m opened this issue Jun 6, 2023 · 4 comments
Assignees
@paulidale
Labels
branch: master Merge to master branch severity: urgent Fixes an urgent issue (exempt from 24h grace period) triaged: bug The issue/pr is/fixes a bug

Comments

@t8m
Copy link
Member

t8m commented Jun 6, 2023

The provider compatibility CI needs fixes as it currently fails.

https://github.com/openssl/openssl/actions/workflows/provider-compatibility.yml

It should be also run on-push for future failures to be more visible.
@t8m t8m added branch: master Merge to master branch triaged: bug The issue/pr is/fixes a bug severity: urgent Fixes an urgent issue (exempt from 24h grace period) labels Jun 6, 2023
@paulidale
Copy link
Contributor

paulidale commented Jun 6, 2023 •
edited

My question is why aren't there any notifications of daily test failures?
We've been hit by their absence before and will be again...

I.e. I'm not convinced we should run this on push, daily should be sufficient.

paulidale added a commit to paulidale/openssl that referenced this issue Jun 6, 2023
@paulidale
kdf test: restrict the version of the FIPS provider
dac193a 
Concatenation tests are provider version specific, limit them to supporting
versions.

Fixes openssl#21134
@t8m
Copy link
Member Author

t8m commented Jun 7, 2023

My question is why aren't there any notifications of daily test failures? We've been hit by their absence before and will be again...

I.e. I'm not convinced we should run this on push, daily should be sufficient.

Because there is no way how to simply query them? But yes, I assume we can run something periodically in zabbix to report these failures @Alich-OpenSSL ?

@paulidale
Copy link
Contributor

An email sent on build failure would be ideal.

No notification on failure isn't good.

@t8m
Copy link
Member Author

t8m commented Jun 7, 2023

Unfortunately the implicit notification from GitHub for scheduled runs go to the person who last touched the .yml file in regards to the schedule: https://docs.github.com/en/actions/monitoring-and-troubleshooting-workflows/notifications-for-workflow-runs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@paulidale paulidale

Labels
branch: master Merge to master branch severity: urgent Fixes an urgent issue (exempt from 24h grace period) triaged: bug The issue/pr is/fixes a bug
Projects
Project Board
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@t8m @paulidale