Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

There is a memory leak vulnerability at line 250 in the /openssl/crypto/pkcs12/p12_crt.c file. #24453

Closed
LuMingYinDetect opened this issue May 22, 2024 · 0 comments
Closed

There is a memory leak vulnerability at line 250 in the /openssl/crypto/pkcs12/p12_crt.c file. #24453

LuMingYinDetect opened this issue May 22, 2024 · 0 comments
Labels
branch: master Merge to master branch branch: 3.0 Merge to openssl-3.0 branch branch: 3.1 Merge to openssl-3.1 branch: 3.2 Merge to openssl-3.2 branch: 3.3 Merge to openssl-3.3 help wanted triaged: bug The issue/pr is/fixes a bug

Comments

@LuMingYinDetect
Copy link

At line 244 in the /openssl/crypto/pkcs12/p12_crt.c file, a pointer variable named p8 is defined. At line 247, the EVP_PKEY2PKCS8 function allocates a dynamic memory area for this variable. If the if statement at line 247 returns false, it indicates that the dynamic memory allocation for p8 was successful. When the if statement at line 249 returns true, the program will jump to the err label via a goto statement at line 250. During this process, the dynamic memory area pointed to by p8 is neither freed, as it is in line 254, nor is it freed in the err label, leading to a memory leak vulnerability, as illustrated below (note that the marked paths in the diagram do not match my description; refer to my description for accuracy):
https://github.com/LuMingYinDetect/openssl_defects/blob/main/openssl_25.png
@LuMingYinDetect LuMingYinDetect added the issue: bug report The issue was opened to report a bug label May 22, 2024
Sashan added a commit to Sashan/openssl that referenced this issue May 22, 2024
@Sashan
fix potential memory leak in PKCS12_add_key_ex()
52d81e2 
function must make sure memorry allocated for `p8`
gets freed in error path. Issue reported by LuMingYinDetect

Fixes openssl#24453
@Sashan Sashan mentioned this issue May 22, 2024
Closed
@t8m t8m added branch: master Merge to master branch triaged: bug The issue/pr is/fixes a bug branch: 3.0 Merge to openssl-3.0 branch branch: 3.1 Merge to openssl-3.1 branch: 3.2 Merge to openssl-3.2 branch: 3.3 Merge to openssl-3.3 and removed issue: bug report The issue was opened to report a bug labels May 22, 2024
Sashan added a commit to Sashan/openssl that referenced this issue Jun 12, 2024
@Sashan
fix potential memory leak in PKCS12_add_key_ex()
28d3b6c 
function must make sure memorry allocated for `p8`
gets freed in error path. Issue reported by LuMingYinDetect

Fixes openssl#24453
Sashan added a commit to Sashan/openssl that referenced this issue Jun 12, 2024
@Sashan
fix potential memory leak in PKCS12_add_key_ex()
844fe89 
function must make sure memorry allocated for `p8`
gets freed in error path. Issue reported by LuMingYinDetect

Fixes openssl#24453
Sashan added a commit to Sashan/openssl that referenced this issue Jun 17, 2024
@Sashan
fix potential memory leak in PKCS12_add_key_ex()
f11ba59 
function must make sure memorry allocated for `p8`
gets freed in error path. Issue reported by LuMingYinDetect

Fixes openssl#24453
openssl-machine pushed a commit that referenced this issue Jun 18, 2024
@Sashan @tmshort
fix potential memory leak in PKCS12_add_key_ex()
32c0969 
function must make sure memorry allocated for `p8`
gets freed in error path. Issue reported by LuMingYinDetect

Fixes #24453

Reviewed-by: Tomas Mraz <tomas@openssl.org>
Reviewed-by: Todd Short <todd.short@me.com>
(Merged from #24456)
openssl-machine pushed a commit that referenced this issue Jun 18, 2024
@Sashan @tmshort
fix potential memory leak in PKCS12_add_key_ex()
fd6d2ee 
function must make sure memorry allocated for `p8`
gets freed in error path. Issue reported by LuMingYinDetect

Fixes #24453

Reviewed-by: Tomas Mraz <tomas@openssl.org>
Reviewed-by: Todd Short <todd.short@me.com>
(Merged from #24456)
openssl-machine pushed a commit that referenced this issue Jun 18, 2024
@Sashan @tmshort
fix potential memory leak in PKCS12_add_key_ex()
3e19925 
function must make sure memorry allocated for `p8`
gets freed in error path. Issue reported by LuMingYinDetect

Fixes #24453

Reviewed-by: Tomas Mraz <tomas@openssl.org>
Reviewed-by: Todd Short <todd.short@me.com>
(Merged from #24456)
openssl-machine pushed a commit that referenced this issue Jun 18, 2024
@Sashan @tmshort
fix potential memory leak in PKCS12_add_key_ex()
dabefe2 
function must make sure memorry allocated for `p8`
gets freed in error path. Issue reported by LuMingYinDetect

Fixes #24453

Reviewed-by: Tomas Mraz <tomas@openssl.org>
Reviewed-by: Todd Short <todd.short@me.com>
(Merged from #24456)
bernd-edlinger pushed a commit to bernd-edlinger/openssl that referenced this issue Jun 21, 2024
@Sashan @bernd-edlinger
fix potential memory leak in PKCS12_add_key_ex()
adccf9b 
function must make sure memorry allocated for `p8`
gets freed in error path. Issue reported by LuMingYinDetect

Fixes openssl#24453

Reviewed-by: Tomas Mraz <tomas@openssl.org>
Reviewed-by: Todd Short <todd.short@me.com>
(Merged from openssl#24456)
bernd-edlinger pushed a commit to bernd-edlinger/openssl that referenced this issue Jun 21, 2024
@Sashan @bernd-edlinger
fix potential memory leak in PKCS12_add_key_ex()
cccc016 
function must make sure memorry allocated for `p8`
gets freed in error path. Issue reported by LuMingYinDetect

Fixes openssl#24453

Reviewed-by: Tomas Mraz <tomas@openssl.org>
Reviewed-by: Todd Short <todd.short@me.com>
(Merged from openssl#24456)
bernd-edlinger pushed a commit to bernd-edlinger/openssl that referenced this issue Jun 21, 2024
@Sashan @bernd-edlinger
fix potential memory leak in PKCS12_add_key_ex()
0f37aab 
function must make sure memorry allocated for `p8`
gets freed in error path. Issue reported by LuMingYinDetect

Fixes openssl#24453

Reviewed-by: Tomas Mraz <tomas@openssl.org>
Reviewed-by: Todd Short <todd.short@me.com>
(Merged from openssl#24456)
bernd-edlinger pushed a commit to bernd-edlinger/openssl that referenced this issue Jun 21, 2024
@Sashan @bernd-edlinger
fix potential memory leak in PKCS12_add_key_ex()
eeaa387 
function must make sure memorry allocated for `p8`
gets freed in error path. Issue reported by LuMingYinDetect

Fixes openssl#24453

Reviewed-by: Tomas Mraz <tomas@openssl.org>
Reviewed-by: Todd Short <todd.short@me.com>
(Merged from openssl#24456)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
branch: master Merge to master branch branch: 3.0 Merge to openssl-3.0 branch branch: 3.1 Merge to openssl-3.1 branch: 3.2 Merge to openssl-3.2 branch: 3.3 Merge to openssl-3.3 help wanted triaged: bug The issue/pr is/fixes a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix potential memory leak in PKCS12_add_key_ex() Sashan/openssl
3 participants
@nhorman @t8m @LuMingYinDetect